[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-5870) Cache invalidation bug: createSQLQuery(String sql) creates SQLQueryImpl with null querySpaces, making UpdateTimestampsCache:isUpToDate always return true

[nodje (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=39782#action_39782 ] 

nodje commented on HHH-5870:
----------------------------

Gail, this is quite a heavy mapping here, our biggest entity indeed.
SQL stmt is very simple, just a basic select with a where condition, it's using 
createCacheableSQLQuery(columns + query).addScalar("id", Hibernate.STRING).setResultTransformer(Transformers.aliasToBean(SearchBean.class)).list();

I'd rather try to add a test case to the existing test suite.
But I need a hand with GitHub. I'm not familiar with it unfortunately.
I have been able to clone the master branch, but want to work on 3.6 branch.
git checkout 3.6 doesn't work, and that's what I understand I have to do from the doc.
Can't find any forum/chat/communication way on GitHub. 
Can you just explain me how to switch on 3.6 please?

------------
And hum, can't believe you removed a working Maven configuration to keep only gradle... 
my 2c opinion...

> Cache invalidation bug: createSQLQuery(String sql) creates SQLQueryImpl with null querySpaces, making UpdateTimestampsCache:isUpToDate always return true
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HHH-5870
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5870
>             Project: Hibernate Core
>          Issue Type: Bug
>          Components: caching (L2)
>    Affects Versions: 3.6.0
>         Environment: OS X 10.6.6 - Java 1.6.0_22
>            Reporter: nodje
>            Priority: Blocker
>
> While investigating a regression seemingly caused by cache problem on an application, I stumbled upon 
> UpdateTimestampsCache:89 method public synchronized boolean isUpToDate(Set spaces, Long timestamp) throws HibernateException 
> always returning true when parameter spaces Set empty.
> This is the cause of my regression: QueryCache gets hit even though returned entities have been updated after the query fired first time.
> While trying to understand what caused Set spaces to be empty - which to me is the cause of the error - I realized it is just created like that in SQLQueryImpl:138.
> SQLQueryImpl(String sql, SessionImplementor session, ParameterMetadata parameterMetadata) {
> 		super( sql, null, session, parameterMetadata );
> 		queryReturns = new ArrayList<NativeSQLQueryReturn>();
> 		querySpaces = null;
> 		callable = false;
> 	}
> While there's probably a way to specify querySpaces (I can only trace it to using addSynchronizedQuerySpace in SQLQuery - which is not referenced in the doc), I believe everybody expect a default behavior, i-e a default querySpace to work with, so that isUpToDate check can work properly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira