[hibernate-issues] [Hibernate-JIRA] Commented: (HSEARCH-795) Move some of SearchFactoryImplementor from spi to impl (and move SPI level contracts up)

[Emmanuel Bernard (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42764#action_42764 ] 

Emmanuel Bernard commented on HSEARCH-795:
------------------------------------------

o SearchFactoryIntegrator vs SearchFactoryImplementor
In my mind, I introduced SearchFactoryIntegrator to separate private SearchFactory usage from frameworks usage.
Does the Infinispan Query module depends on SearchFactoryImplementor only? Or is it depending on SearchFactoryImplementor?

=> Sanne
It's built on top of SearchFactoryIntegrator, in some tests this is
cast to SearchFactoryImplementor to be able to verify some state but I
think you can ignore that.
Currently Query needs only #getDocumentBuildersIndexedEntities(), in
worst case we could expose that.
=> Hardy
If SearchFactoryImplementor could disappear and have one less interface, I'm +1

> Move some of SearchFactoryImplementor from spi to impl (and move SPI level contracts up)
> ----------------------------------------------------------------------------------------
>
>                 Key: HSEARCH-795
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-795
>             Project: Hibernate Search
>          Issue Type: Improvement
>            Reporter: Emmanuel Bernard
>             Fix For: 4.0
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira