[hibernate-issues] [Hibernate-JIRA] Updated: (HHH-4943) ilike support is incomplete

[Gail Badner (JIRA)]

     [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gail Badner updated HHH-4943:
-----------------------------

    Fix Version/s:     (was: 3.6.5)

I ran into problems backporting this. I'm not familiar enough with this to be sure about the appropriate way to backport to 3.6.

Strong, if it really should be backported to 3.6, please create a new issue for the backport so it can be fixed in 3.6.6.

Thanks,
Gail

> ilike support is incomplete
> ---------------------------
>
>                 Key: HHH-4943
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4943
>             Project: Hibernate Core
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.3.2
>         Environment: 3.3.2GA
> MySQL/PostgreSQL
>            Reporter: James Nobis
>            Assignee: Strong Liu
>             Fix For: 4.0.0.Beta1
>
>
> ILIKE is currently supported for PostgreSQL in:
> hibernate-distribution-3.3.2.GA/project/core/src/main/java/org/hibernate/criterion/IlikeExpression.java:
>       if ( dialect instanceof PostgreSQLDialect ) {
>          return columns[0] + " ilike ?";
>       }
>       else {
>          return dialect.getLowercaseFunction() + '(' + columns[0] + ") like ?";
>       }
>       //TODO: get SQL rendering out of this package!
> 1) This should be in the Dialect
> 2) PostgreSQL isn't the only DB with ILIKE
> 3) using instanceof for this is just sloppy
> 4) this implementation using getLowercaseFunction works with MySQL but fails with DBs like Firebird

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira