[hibernate-issues] [Hibernate-JIRA] Commented: (HV-486) Remove getMethod() from MethodConstraintViolation

Hardy Ferentschik (JIRA) noreply at atlassian.com
Thu Jun 9 08:27:25 EDT 2011


    [ http://opensource.atlassian.com/projects/hibernate/browse/HV-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42555#action_42555 ] 

Hardy Ferentschik commented on HV-486:
--------------------------------------

Thinking about it more, removing _getMethod()_ is maybe introducing another inconsistency. The method is actually passed to us by the client of HV via _validateParameter_ and Co. Part of  _ConstraintViolation_ is to give access to the actual validated instance (the root bean). This is also the case for method validation and as an extension one could argue that you also want access to the method passed to the validate call. From this point of view the API is consistent and I think we should leave it as is. WDYT

> Remove getMethod() from MethodConstraintViolation
> -------------------------------------------------
>
>                 Key: HV-486
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-486
>             Project: Hibernate Validator
>          Issue Type: Improvement
>          Components: engine
>            Reporter: Gunnar Morling
>            Assignee: Hardy Ferentschik
>             Fix For: 4.2.0.Final
>
>
> The class {{MethodConstraintViolation}} currently has a member {{getMethod()}} which returns a {{java.lang.reflect.Method}}. In order to align representation of methods throughout the meta API this should be replaced with something like {{getName()}} and {{getParameterType()}}.
> We also might consider to return {{MethodDescriptor}} here.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the hibernate-issues mailing list