[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-6300) Create EntityBindingState implementation for annotations

[Gail Badner (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42560#action_42560 ] 

Gail Badner commented on HHH-6300:
----------------------------------

Pull request: https://github.com/hibernate/hibernate-core/pull/107

I moved all the logic for EntityBinding-specific data into EntityBindingStateImpl, except for those pieces that are initialized using other state objects (e.g., discriminator, attributes). 

1) EntityBinder delegates Annotations processing to EntityBindingStateImpl. 
2) EntityBindingStateImpl fields are final, to ensure that they are always set, but only once. 
3) EntityBindingStateImpl contains general methods for extracting annotations values. I just noticed there are already similar methods in JandexHelper, so those should probably be removed. 

I would also like to create (with different Jira issues): 
- EntityDomainState (for initializing entity-name and entity-mode-related data) 
- EntityRelationalState (for initializing the base table) 
- "state" object for initializing EntityIdentifier objects (not sure if 1 state object would suffice) 

Once those are created, I could remove all setters from EntityBinding. 

WDYT?

> Create EntityBindingState implementation for annotations
> --------------------------------------------------------
>
>                 Key: HHH-6300
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6300
>             Project: Hibernate Core
>          Issue Type: Task
>          Components: core
>            Reporter: Gail Badner
>            Assignee: Gail Badner
>             Fix For: 4.0.0.next
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira