[hibernate-issues] [Hibernate-JIRA] Commented: (HSEARCH-746) Split API, SPI and private classes into separate packages
Emmanuel Bernard (JIRA)
noreply at atlassian.com
Tue Jun 21 09:24:53 EDT 2011
[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42687#action_42687 ]
Emmanuel Bernard commented on HSEARCH-746:
------------------------------------------
TODO
engine and following (alphabetically)
o SearchFactoryIntegrator vs SearchFactoryImplementor
In my mind, I introduced SearchFactoryIntegrator to separate private SearchFactory usage from frameworks usage.
Does the Infinispan Query module depends on SearchFactoryImplementor only? Or is it depending on SearchFactoryImplementor?
=> Sanne
It's built on top of SearchFactoryIntegrator, in some tests this is
cast to SearchFactoryImplementor to be able to verify some state but I
think you can ignore that.
Currently Query needs only #getDocumentBuildersIndexedEntities(), in
worst case we could expose that.
=> Hardy
If SearchFactoryImplementor could disappear and have one less interface, I'm +1
> Split API, SPI and private classes into separate packages
> ---------------------------------------------------------
>
> Key: HSEARCH-746
> URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-746
> Project: Hibernate Search
> Issue Type: New Feature
> Components: analyzer, directory provider, documentation, engine, integration, mapping, massindexer, optimizer, query
> Reporter: Emmanuel Bernard
> Assignee: Emmanuel Bernard
> Fix For: 4.0.0.Alpha1
>
>
> API should go into a functionally named package
> SPI should go into a functionally named package .spi eg org.hibernate.search.bridge.spi
> private classes should go into a functionally named package .impl eg org.hibernate.search.bridge.impl
> Note that the distinction between API and SPI is a bit blurry and needs to be refined by the team as a whole:
> - is it any "public" API not directly called by the user application (ie a Bridge would be SPI). That's the definition followed by the Hibernate Core team.
> - is it any API targeted at frameworks integrating with Hibernate Search as opposed to APIs (eg SearchConfiguration)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the hibernate-issues
mailing list