[hibernate-issues] [Hibernate-JIRA] Commented: (HSEARCH-323) Fault tolerant FSSlaveDirectoryProvider

[Sanne Grinovero (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=40174#action_40174 ] 

Sanne Grinovero commented on HSEARCH-323:
-----------------------------------------

Hi Oliver, thanks great patch. Did you already sign the contributor agreement https://cla.jboss.org ? I need that to be able to apply it.
I'm still finding some minor corrections:
 - getDirectory() will return a new RAMDirectory every time it's invoked when the master was not started yet. I'd add a check for !=null
 - The dummyDirectory variable is not volatile nor using any memory barrier. you've added it just below the comment 
{code}variables having visibility granted by a read of "current"{code}
but that's not the case for this instance. You should make it volatile or use some synchronization. Ideally an AtomicReference, so if it's being swapped while a second thread initializes it you won't miss closing one of the instances.

I can take care of this change if my explanation wasn't clear.

> Fault tolerant FSSlaveDirectoryProvider
> ---------------------------------------
>
>                 Key: HSEARCH-323
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-323
>             Project: Hibernate Search
>          Issue Type: Improvement
>          Components: directory provider
>    Affects Versions: 3.1.0.GA
>            Reporter: Oliver Siegmar
>         Attachments: FSSlaveDirectoryProvider.java.diff, FSSlaveDirectoryProvider2.java.diff
>
>
> The current implementation of FSSlaveDirectoryProvider requires an existent master repository at startup. In our environment it could happen, that the master repository is built some time after the clients (using the FSSlaveDirectoryProvider) are being started. It'd be good to have a more fault tolerant FSSlaveDirectoryProvider, that would retry to initialize itself (using a TimerTask for example). The configuration should allow to enable/disable this feature and to specify the retry interval and period.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira