[hibernate-issues] [Hibernate-JIRA] Commented: (HV-442) Make clear in the documentation which types are supported for built-in constraints

[Gunnar Morling (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HV-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=40179#action_40179 ] 

Gunnar Morling commented on HV-442:
-----------------------------------

Hehe. Do you think we might remove this "feature"? 

The problem I see with it is that it's just not obvious, that these constraints refer to the number represented by a given String and not its length. And there is no chance to learn about this other then reading the reference guide as this naturally is not mentioned at the constraints' JavaDocs which only can describe what's part of the spec.

Of course there might be users relying on this now. So we might deprecate this in HV 4.2 and remove the suppport in 4.3 WDYT?


> Make clear in the documentation which types are supported for built-in constraints
> ----------------------------------------------------------------------------------
>
>                 Key: HV-442
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-442
>             Project: Hibernate Validator
>          Issue Type: Improvement
>          Components: documentation
>    Affects Versions: 4.1.0.Final
>            Reporter: Gunnar Morling
>             Fix For: 4.2.0.CR1
>
>
> Hibernate Validator supports the standard constraints defined in the Bean Validation AP at more types than required by the specification. E.g. @Min/@Max are supported for Strings, which is beyond what's defined in the spec.
> In order to avoid irritations we should make clear in the documentation (http://docs.jboss.org/hibernate/validator/4.1/reference/en-US/html/validator-usingvalidator.html#validator-defineconstraints-builtin) which types are supported by HV in addition to the BV specification (for @Past/@Future we already do describe this for the Joda types for example).
> Furthermore the annotation processor documentation says (reference guide and web site):
> {quote}
> Have you ever caught yourself by unintentionally doing things like
> annotating Strings with @Min to specify a minimum length (instead of using @Size)
> ...?
> Then the Hibernate Validator Annotation Processor is the right thing for you.
> {quote}
> This example is misleading, as the AP won't mark this situation as an erronous (the described misunderstanding, that @Min would refer to the String length can still happen, though).
> This issue is based on a post in the HV forum (https://forum.hibernate.org/viewtopic.php?f=9&t=1009701).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira