[hibernate-issues] [Hibernate-JIRA] Resolved: (HSEARCH-701) Avoid reflection used for debugging purposes during query results processing

Hardy Ferentschik (JIRA) noreply at atlassian.com
Mon Mar 14 10:08:08 EDT 2011


     [ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hardy Ferentschik resolved HSEARCH-701.
---------------------------------------

    Resolution: Fixed

> Avoid reflection used for debugging purposes during query results processing
> ----------------------------------------------------------------------------
>
>                 Key: HSEARCH-701
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-701
>             Project: Hibernate Search
>          Issue Type: Improvement
>            Reporter: Sanne Grinovero
>            Assignee: Sanne Grinovero
>             Fix For: 3.4.0.Beta1
>
>
> In methods:
> org.hibernate.search.engine.DocumentBuilderHelper.processFieldsForProjection(PropertiesMetadata, String[], Object[], Document, ContextualException2WayBridge)
> org.hibernate.search.engine.DocumentBuilderHelper.getDocumentFields(SearchFactoryImplementor, Class<?>, Document, String[])
> the ContextualException2WayBridge is used to provide nice error messages, but pushMethod of this helper requires a String, while the objects being passed are Method.getName() (which also returns a String).
> It seems that performing these getName() provides a performance penalty, we should see if it's not possible to invoke the method only in case an error is actually thrown.
> Better alternative - as the getName() was also an issue in other points - is to improve the getName() implementation to define this as a constant field;

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the hibernate-issues mailing list