[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-3854) Issue with greedy loading of associations (default-lazy=false )

[HG (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=40216#action_40216 ] 

HG commented on HHH-3854:
-------------------------

I did face this problem as well. But as we were not auditing the relations and just the individual entities, I just replaced the line :

//value = versionsReader.getSessionImplementor().getFactory().getEntityPersister(referencedEntityName).createProxy((Serializable) entityId, new ToOneDelegateSessionImplementor(versionsReader, entityClass, entityId, revision, verCfg));

with value = null;

in the method mapToEntityFromMap(...)

This insures that no null pointer occured in evaluating 'value'.

This workaround works when you dont need to audit relations, i.e. only in cases where you need to audit just the individual entities.

> Issue with greedy loading of associations (default-lazy=false )
> ---------------------------------------------------------------
>
>                 Key: HHH-3854
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854
>             Project: Hibernate Core
>          Issue Type: Bug
>          Components: envers
>         Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate-envers (from trunk)
>            Reporter: Amar Singh
>         Attachments: envers-HHH-3854-testcases.patch, greedy-loading.zip
>
>
> I have an Entity GP which has a many to one association to entity CA.
> <?xml version="1.0"?>
> <!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD 3.0//EN"
>                                    "http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
> <hibernate-mapping package="org.hibernate.envers.test.integration.onetoone.bidirectional" default-lazy="false">
> <class name="BidirectionalRefIngPK" table="BIDIRECTIONAL_REFERENCING_ENTITY">
>   <id name="id" type="long" column="BIDIRECTIONAL_REFERENCING_ID" >
>    	<generator class="native"/>
>   </id>
>   <property name="data"/>
>   <many-to-one name="reference" cascade="save-update" class="BidirectionalRefEdPK" column="BIDIRECTIONAL_REFERENCED_ID"/>
>  </class>
>  
>  <class name="BidirectionalRefEdPK" table="BIDIRECTIONAL_REFERENCED_ENTITY">
>   <id name="longId" type="long" column="BIDIRECTIONAL_REFERENCED_ID">
>    <generator class="native"/>
>   </id>
>   <property name="data"/>
>  </class>
>  
> </hibernate-mapping>
> With this when I load a previous version of BidirectionalRefIngPK, the loading mechanism tries to create a proxy for BidirectionalRefEdPK, but in my case lazy is false so an internal call to createProxy will return NULL hence .
> This happens in ToOneIdMapper.java in method mapToEntityFromMap around line 82, which then internally calls for AbstractEntityTuplizer.java line 395 for getProxyFactory() ending in NULL pointer exception because proxy factory is null as mine is a greedy loading. 
> TO REPRODUCE
> ~~~~~~~~~~~~~
> Please find a zipped folder attached. The zipped file has 4 files:
> - GreedyLoading.java (actual testng test case)
> - BidirectionalRefEdPK.java (Entity 1)
> - BidirectionalRefIngPK.java (Entity 2)
> - greedyloading.hbm.xml
> Please place the three java files in its package (org.hibernate.envers.test.integration.onetoone.bidirectional), couldn't find the right package so created test case accordingly. Put the greedyloading.hbm.xml in src/test/resources.
> Now when testng runs GreedyLoading.java you should see NPE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira