[hibernate-issues] [Hibernate-JIRA] Commented: (HSEARCH-675) Move to i18n logs and exception via JBoss Logging

[Sanne Grinovero (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42389#action_42389 ] 

Sanne Grinovero commented on HSEARCH-675:
-----------------------------------------

Hi Davide,
thanks for the preview;
some first comments:
{code}- hibernateQuery.setTimeout( 5, TimeUnit.MINUTES );
+ hibernateQuery.setTimeout( 300, TimeUnit.SECONDS );{code}
this _might_ make sense, but make sure you don't include such changes in a patch related to Logging only.
{code}- org.hibernate.search.util.LoggerFactory.make();
+ org.hibernate.search.util.logging.LoggerFactory.make();{code}
I think it makes sense to use the new package, but you should not move AND change files in the same commit; could you change the logic first, and then apply a latest isolated commit which does only move the class to a new package? If you do both at the same time, it's hard to track what you exactly had to change; also it would be nice to be able to pick just the important changes, and eventually decide if we want to also move the package or not, in independent form.
\\
 # You don't need to add logging messages for tests; actually we might want to avoid useless log methods in the main package; is that possible? in case you need, you could lower the message severity.
 # Don't reformat the pom.xml; I see you likely needed to change something, but it's hard to tell what was needed and what was white spacing. Again, it's possible that whitespacing is currently wrong and you can propose a commit for that fixing it, but keep it independent from logging related commits (it's totally fine however to have such commits in the same pull request, just use a different commit message so that we can inspect changes in isolation).

\\
thanks!

> Move to i18n logs and exception via JBoss Logging
> -------------------------------------------------
>
>                 Key: HSEARCH-675
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-675
>             Project: Hibernate Search
>          Issue Type: New Feature
>          Components: engine
>            Reporter: Emmanuel Bernard
>            Assignee: Davide D'Alto
>             Fix For: 4.0.0.Alpha1
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira