[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-6817) Logging of strings containing the percent character broken

[Fred Toussi (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44303#comment-44303 ] 

Fred Toussi commented on HHH-6817:
----------------------------------

A stack trace below:

java.util.UnknownFormatConversionException: Conversion = '3'
	at java.util.Formatter.checkText(Formatter.java:2503)
	at java.util.Formatter.parse(Formatter.java:2485)
	at java.util.Formatter.format(Formatter.java:2414)
	at java.util.Formatter.format(Formatter.java:2367)
	at java.lang.String.format(String.java:2769)
	at org.jboss.logging.Log4jLogger.doLogf(Log4jLogger.java:48)
	at org.jboss.logging.Logger.logf(Logger.java:2143)
	at org.jboss.logging.DelegatingBasicLogger.debugf(DelegatingBasicLogger.java:227)
	at org.hibernate.internal.util.EntityPrinter.toString(EntityPrinter.java:121)
	at org.hibernate.event.internal.AbstractFlushingEventListener.logFlushResults(AbstractFlushingEventListener.java:134)
	at org.hibernate.event.internal.AbstractFlushingEventListener.flushEverythingToExecutions(AbstractFlushingEventListener.java:110)
	at org.hibernate.event.internal.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:49)
	at org.hibernate.internal.SessionImpl.flush(SessionImpl.java:1082)
	at org.hibernate.test.unionsubclass.UnionSubclassTest.testUnionSubclassManyToOne(UnionSubclassTest.java:227)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
	at org.hibernate.testing.junit4.ExtendedFrameworkMethod.invokeExplosively(ExtendedFrameworkMethod.java:63)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
	at org.hibernate.testing.junit4.FailureExpectedHandler.evaluate(FailureExpectedHandler.java:59)
	at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
	at org.hibernate.testing.junit4.BeforeClassCallbackHandler.evaluate(BeforeClassCallbackHandler.java:43)
	at org.hibernate.testing.junit4.AfterClassCallbackHandler.evaluate(AfterClassCallbackHandler.java:42)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:24)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:71)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:199)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:62)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:120)


> Logging of strings containing the percent character broken
> ----------------------------------------------------------
>
>                 Key: HHH-6817
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6817
>             Project: Hibernate Core
>          Issue Type: Bug
>    Affects Versions: 4.0.0.CR6
>         Environment: HSQLDB 2.2.6 snapshot
>            Reporter: Fred Toussi
>            Priority: Blocker
>
> The method AbstractTypeDescriptor#extractLoggableRepresentation(T value) does not escape the percent character. Possible workaround below:
> 	public String extractLoggableRepresentation(T value) {
>         if (value == null)
>             return null;
>         String stringValue = value.toString();
>         return stringValue.replace("%", "%%");
> 	}
> The return value is used for logging, where the string is used as the format argument to java.lang.String#format(String format, Object... args). The percent character is interpreted as a format identifier and causes an exception as what follows is not necessarily a valid format template.  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira