[hibernate-issues] [Hibernate-JIRA] Commented: (BVAL-285) ValidatorFactory#close should clearly state post condidtions

Hardy Ferentschik (JIRA) noreply at atlassian.com
Wed Apr 4 16:36:48 EDT 2012


    [ https://hibernate.onjira.com/browse/BVAL-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46185#comment-46185 ] 

Hardy Ferentschik commented on BVAL-285:
----------------------------------------

I think the problem becomes then the _ConstraintValidatorFactory_. AFAIU one aim of _close_ is to release eg the instantiated _ConstraintValidator_ instances via _ConstraintValidatorFactory#releaseInstance_. You need some sort of life cycle. As a side effect if I am trying to the use a _Validator_ after _close_ was called I am getting into trouble.

> ValidatorFactory#close should clearly state post condidtions 
> -------------------------------------------------------------
>
>                 Key: BVAL-285
>                 URL: https://hibernate.onjira.com/browse/BVAL-285
>             Project: Bean Validation
>          Issue Type: Improvement
>          Components: spec-general
>    Affects Versions: 1.1.next
>            Reporter: Hardy Ferentschik
>
> The Javadocs for ValidatorFactory#close says:
> {quote}
> After the _ValidatorFactory_ instance is closed, it is not allowed to call:
> * methods of this _ValidatorFactory_ instance
> * methods of _Validator_ instances created by this _ValidatorFactory_
> {quote}
> It does, however, not specified what happens if such a method is called. I think with this wording a post conditions needs to be specified, eg a _ValidationException_ will be thrown. Otherwise the docs should say that the behavior is unspecified if any of the mentioned methods is called after calling _close()_

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the hibernate-issues mailing list