[hibernate-issues] [Hibernate-JIRA] Commented: (HV-532) Remove package cycle between "core" and "descriptor" packages

[Gunnar Morling (JIRA)]

    [ https://hibernate.onjira.com/browse/HV-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46270#comment-46270 ] 

Gunnar Morling commented on HV-532:
-----------------------------------

I had a short look into this issue. I think this needs a larger refactoring which will likely take some time.

Therefore I'd also say let's move this to HV 5. Maybe we need some changes to the meta-model due to method validation anyways, so that would be a good opportunity. 

Only internal packages are concerned, I don't expect any impact on the public API.

> Remove package cycle between "core" and "descriptor" packages
> -------------------------------------------------------------
>
>                 Key: HV-532
>                 URL: https://hibernate.onjira.com/browse/HV-532
>             Project: Hibernate Validator
>          Issue Type: Task
>          Components: engine
>    Affects Versions: 4.2.0.Final
>            Reporter: Gunnar Morling
>            Assignee: Gunnar Morling
>             Fix For: 4.3.0.CR1
>
>
> There is a cyclic dependency between the packages {{org.hibernate.validator.metadata.core}} and {{org.hibernate.validator.metadata.descriptor}} which should be removed. 
> I think the general problem is that {{ConstraintDescriptorImpl}} (which is now part of the "descriptor" model) is used globally in HV. Probably there should be a corresponding node in the internal model (actually we already have this with {{MetaConstraint}}), of which {{ConstraintDescriptorImpl}} would only be a light-weight view for external meta-model users.
> In {{ConstraintDescriptorImpl}} there is also a lot of logic related to annotation retrieval, which we now might move into the provider hierarchy similar to {{BeanMetaDataImpl}}.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira