[hibernate-issues] [Hibernate-JIRA] Issue Comment Edited: (HHH-7145) There is a typo/syntax error in the first example under 2.2.2.3. Embedded objects (aka components)

[Tracy Logan (JIRA)]

    [ https://hibernate.onjira.com/browse/HHH-7145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45817#comment-45817 ] 

Tracy Logan edited comment on HHH-7145 at 3/3/12 5:57 PM:
----------------------------------------------------------

Per https://github.com/hibernate/hibernate-orm/wiki/Contributing-Code, the Pull Request URL for my changes is https://github.com/hibernate/hibernate-orm/pull/284



      was (Author: logantracyo):
    Per https://github.com/hibernate/hibernate-orm/wiki/Contributing-Code, the Pull Request URL is https://github.com/hibernate/hibernate-orm/pull/284


  
> There is a typo/syntax error in the first example under 2.2.2.3. Embedded objects (aka components)
> --------------------------------------------------------------------------------------------------
>
>                 Key: HHH-7145
>                 URL: https://hibernate.onjira.com/browse/HHH-7145
>             Project: Hibernate ORM
>          Issue Type: Improvement
>          Components: documentation
>         Environment: 3.1 beta 9
>            Reporter: Tracy Logan
>            Priority: Trivial
>
> The example given under section 2.2.2.3. Embedded objects (aka components) contains the following:
> {code:java}
>     @AttributeOverrides( {
>             @AttributeOverride(name="iso2", column = @Column(name="bornIso2") ),
>             @AttributeOverride(name="name", column = @Column(name="bornCountryName") )
>     } )
> {code}
> However, @AttributeOverrides actually takes an array, so the correct syntax changes the curly braces to square brackets:
> {code:java}
>     @AttributeOverrides( [
>             @AttributeOverride(name="iso2", column = @Column(name="bornIso2") ),
>             @AttributeOverride(name="name", column = @Column(name="bornCountryName") )
>     ] )
> {code}
> This is of course a trivial (though helpful!) fix; I plan to use it to gain experience contributing, and will edit this ticket to add a patch (or pull request?) shortly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira