[hibernate-issues] [Hibernate-JIRA] Commented: (HSEARCH-1049) includePaths bombs on inclusion of id members

[Sanne Grinovero (JIRA)]

    [ https://hibernate.onjira.com/browse/HSEARCH-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45821#comment-45821 ] 

Sanne Grinovero commented on HSEARCH-1049:
------------------------------------------

Hi Marc,
I've found branch HSEARCH-1049 on https://github.com/mschipperheyn/hibernate-search .
Is that the correct place? I couldn't find the tests Davide suggested. Could you please add a test?

That's an important aspect of a patch, as it makes sure the fix works now and above all that it will work as you expect in the future.

All functionality needs to be covered by tests, otherwise when someone will introduce another feature or do some cleanup (which I'm doing on this area!) a single line of code like that might be overzealous removed. There should be a failing test if I remove your last commit.

> includePaths bombs on inclusion of id members
> ---------------------------------------------
>
>                 Key: HSEARCH-1049
>                 URL: https://hibernate.onjira.com/browse/HSEARCH-1049
>             Project: Hibernate Search
>          Issue Type: Bug
>          Components: engine
>    Affects Versions: 4.1.0.Beta2
>            Reporter: Marc Schipperheyn
>            Priority: Blocker
>             Fix For: 4.1.0.Final
>
>
> When I include id members on includePaths, I get 
> Found invalid @IndexedEmbedded->paths configured on class nl.project.model.Item, member subitem: item.id
> I use ids a lot and in many cases they are all I'm interested in.
> E.g.
> @IndexedEmbedded(prefix="location.",includePaths={"city.id","city.city","country.id","city.region.id"})
> 	public Address getAddress() {
> 		return address;
> 	}
> will indicate all id fields as erronous.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira