[hibernate-issues] [Hibernate-JIRA] Commented: (OGM-134) Fix logs in BasicGridBinder

[Sanne Grinovero (JIRA)]

    [ https://hibernate.onjira.com/browse/OGM-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45961#comment-45961 ] 

Sanne Grinovero commented on OGM-134:
-------------------------------------

Reminder: the new tracef will need guarding to avoid unwanted invocation of extractLoggableRepresentation

> Fix logs in BasicGridBinder
> ---------------------------
>
>                 Key: OGM-134
>                 URL: https://hibernate.onjira.com/browse/OGM-134
>             Project: Hibernate OGM
>          Issue Type: Bug
>            Reporter: Emmanuel Bernard
>
> From Guillaume
> I have noticed that the BasicGridBinder has a problem when it logs the
> bindding  ( BasicGridBinder.bind(Tuple, X, String[] ) method).
> Actually, the trace is "binding [$s] to parameter(s) $s" but it should be
> "binding [thevalue] to parameter(s) theparameter".
> It can be fixed easily by modifying the two calls to log.tracef() (line 70
> and 76) respectively like that:
> log.tracef( "binding [null] to parameter [%1$s]", name );
> and
> log.tracef( "binding [%1$s] to parameter(s) %2$s",
> javaDescriptor.extractLoggableRepresentation( value ), Arrays.toString(
> names ) );

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira