[hibernate-issues] [Hibernate-JIRA] Commented: (HSEARCH-1075) FSSlaveDirectoryProvider JMS configuration documentation is incomplete

[Eli Colner (JIRA)]

    [ https://hibernate.onjira.com/browse/HSEARCH-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46078#comment-46078 ] 

Eli Colner commented on HSEARCH-1075:
-------------------------------------

Yes, good point.  I agree also about removing the tip.  It seems clear enough to mention that overlapping copies are ignored.  The user should be able to optimize for their requirements based on knowing there's room for some error.  I was confused about what to expect as the index grows and the copy operation start to finish grows with it... I feel much better after looking at the code :)

> FSSlaveDirectoryProvider JMS configuration documentation is incomplete
> ----------------------------------------------------------------------
>
>                 Key: HSEARCH-1075
>                 URL: https://hibernate.onjira.com/browse/HSEARCH-1075
>             Project: Hibernate Search
>          Issue Type: Improvement
>          Components: documentation
>    Affects Versions: 4.0.0.Final
>         Environment: all
>            Reporter: Eli Colner
>            Priority: Minor
>              Labels: documentation
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The documentation for 'hibernate.search.default.refresh' property states that "The refresh period should be higher that the expected copy time." which is misleading imo.  It should read "The refresh period represents the least amount of time that slaves will be out of sync with the master.  It is recommended that the refresh period be higher than the expected copy time, however if the value becomes insufficient then the default implementation of FSSlaveDirectoryProvider will prevent multiple copies from occurring simultaneously using a mutex lock.  It's safe to set this value low anticipating that as your index grows the lock will be used appropriately."
> Based on the code, I believe the default value to be very high... but that's a separate issue.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira