[hibernate-issues] [Hibernate-JIRA] Commented: (HV-538) Perform a profiling of the HV code in order to identify performance bottlenecks
Hardy Ferentschik (JIRA)
noreply at atlassian.com
Tue Mar 27 05:08:50 EDT 2012
[ https://hibernate.onjira.com/browse/HV-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46088#comment-46088 ]
Hardy Ferentschik commented on HV-538:
--------------------------------------
Some observations from Gunnar:
{quote}
* The logging around Contracts#assertNotNull() caused very many
invocations of String#format(), also if the asserted value actually
was not null, as MESSAGES.mustNotBeNull( "bla" ) was passed as
parameter. I've changed this by pushing the creation of the message
into the actual null case [1].
* The logging generally causes invocations of String#format() which I
think are are superfluous. More specifically format() is also invoked
if a given log message doesn't have any parameters. AFAICS the message
could directly be returned in that case. WDYT? I think we might create
a ticket against LOGTOOLS for this.
* When parsing mapping XML files, a new JAXBContext was created for
each input stream. I think we can re-use the same instance for several
input streams [2].
[1] https://github.com/gunnarmorling/hibernate-validator/commit/e5259254f8cd89e68821e9a0ffbf32ceddccfe71
[2] https://github.com/gunnarmorling/hibernate-validator/commit/8a190275e9ed37eafd43cc362a8c5916a8737174
{quote}
> Perform a profiling of the HV code in order to identify performance bottlenecks
> -------------------------------------------------------------------------------
>
> Key: HV-538
> URL: https://hibernate.onjira.com/browse/HV-538
> Project: Hibernate Validator
> Issue Type: Improvement
> Components: engine
> Reporter: Gunnar Morling
> Assignee: Gunnar Morling
> Fix For: 4.3.0.Beta1
>
>
> Potential issues include:
> * handling of the {{Path}} API within the validation routine
> * creation of the descriptor model in {{BeanMetaDataImpl}}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the hibernate-issues
mailing list