[hibernate-issues] [Hibernate-JIRA] Issue Comment Edited: (HHH-7319) ServiceContributingIntegrator do not have access to the configuration and cannot adjust service registration accordingly

[Steve Ebersole (JIRA)]

    [ https://hibernate.onjira.com/browse/HHH-7319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46648#comment-46648 ] 

Steve Ebersole edited comment on HHH-7319 at 5/14/12 10:34 AM:
---------------------------------------------------------------

Do we want each {{Integrator}} to be responsible for enabled/disabled checking (which is how this is done today)?  Or do we look at more centralized way to let the {{Integrator}} tell ORM whether it is enabled/disabled?

{code:title=Integrator.java|borderStyle=solid}
public interface Integrator {
    /**
     * Determine whether this Integrator should be considered enabled.  Implication of {@code false} 
     * is that the Integrator will be skipped in all "integration and disintegration activities"
     */
    public boolean isEnabled(Map<?,?> settings);
    ...
}
{code}

(totally a guess at the signature)

      was (Author: steve):
    Do we want each {{Integrator}} to be responsible for enabled/disabled checking (which is how this is done today)?  Or do we look at more centralized way to let the {{Integrator}} tell ORM whether it is enabled/disabled?

{code:Integrator.java|borderStyle=solid}
public interface Integrator {
    /**
     * Determine whether this Integrator should be considered enabled.  Implication of {@code false} 
     * is that the Integrator will be skipped in all "integration and disintegration activities"
     */
    public boolean isEnabled(Map<?,?> settings);
    ...
}
{code}

(totally a guess at the signature)
  
> ServiceContributingIntegrator do not have access to the configuration and cannot adjust service registration accordingly
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HHH-7319
>                 URL: https://hibernate.onjira.com/browse/HHH-7319
>             Project: Hibernate ORM
>          Issue Type: Improvement
>            Reporter: Emmanuel Bernard
>
> In Hibernate OGM, I don't want to set my custom service initiators unless I know it is explicitly being used.
> I cannot do that today because ServiceContributingIntegrator does not have access to the configuration. 
> I had to write all my service initiators so that they look at the configuration and delegate to the "default" service initiator. That's a lot of redundant code. I wonder if we can do better.
> See https://github.com/hibernate/hibernate-ogm/blob/master/hibernate-ogm-core/src/main/java/org/hibernate/ogm/service/impl/OgmIntegrator.java

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira