[hibernate-issues] [JIRA] (HHH-13986) SequenceHiLoGeneratorNoIncrementTest is not testing the right Optimiser

[Sanne Grinovero (JIRA)]

Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A99e61e65-956b-4a21-b29c-06057642e9ea ) *created* an issue

Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiZDFjNzM1MjQ1MjFkNGU1NTgxOWU0OTA0MWYwYjBjZWYiLCJwIjoiaiJ9 ) / Task ( https://hibernate.atlassian.net/browse/HHH-13986?atlOrigin=eyJpIjoiZDFjNzM1MjQ1MjFkNGU1NTgxOWU0OTA0MWYwYjBjZWYiLCJwIjoiaiJ9 ) HHH-13986 ( https://hibernate.atlassian.net/browse/HHH-13986?atlOrigin=eyJpIjoiZDFjNzM1MjQ1MjFkNGU1NTgxOWU0OTA0MWYwYjBjZWYiLCJwIjoiaiJ9 ) SequenceHiLoGeneratorNoIncrementTest is not testing the right Optimiser ( https://hibernate.atlassian.net/browse/HHH-13986?atlOrigin=eyJpIjoiZDFjNzM1MjQ1MjFkNGU1NTgxOWU0OTA0MWYwYjBjZWYiLCJwIjoiaiJ9 )

Issue Type: Task Assignee: Unassigned Components: hibernate-core Created: 27/Apr/2020 14:13 PM Priority: Major Reporter: Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A99e61e65-956b-4a21-b29c-06057642e9ea )

The `org.hibernate.id.SequenceHiLoGeneratorNoIncrementTest` test seems designed to test `LegacyHiLoAlgorithmOptimizer`, however an initialization failure is triggered making the test actually verify the samantics of the fallback optimizer.

The mistake is best observed by adding a breakpoint in `org.hibernate.id.enhanced.OptimizerFactory#buildOptimizer(java.lang.String, java.lang.Class, int)` .

Unfortunately fixing the test will have it change the asserted values; since the goal of this test is to verify strict consistency with the legacy behaviour we need to be careful.

( https://hibernate.atlassian.net/browse/HHH-13986#add-comment?atlOrigin=eyJpIjoiZDFjNzM1MjQ1MjFkNGU1NTgxOWU0OTA0MWYwYjBjZWYiLCJwIjoiaiJ9 ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-13986#add-comment?atlOrigin=eyJpIjoiZDFjNzM1MjQ1MjFkNGU1NTgxOWU0OTA0MWYwYjBjZWYiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100125- sha1:c966059 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/hibernate-issues/attachments/20200427/301f9d50/attachment.html