[hibernate-issues] [JIRA] (HHH-13879) Slow query log should use System#nanoTime not System#currentTimeMillis

[Vlad Mihalcea (JIRA)]

Vlad Mihalcea ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Af5e8c0d3-3aae-4bb4-a4e1-25463d60d232 ) *commented* on HHH-13879 ( https://hibernate.atlassian.net/browse/HHH-13879?atlOrigin=eyJpIjoiMThmODI2Nzc2ZWVhNDI5MTk3MTJhYjFkZTBkMGYzOWUiLCJwIjoiaiJ9 )

Re: Slow query log should use System#nanoTime not System#currentTimeMillis ( https://hibernate.atlassian.net/browse/HHH-13879?atlOrigin=eyJpIjoiMThmODI2Nzc2ZWVhNDI5MTk3MTJhYjFkZTBkMGYzOWUiLCJwIjoiaiJ9 )

Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A99e61e65-956b-4a21-b29c-06057642e9ea ) The major problem with currentTimeMillis() is that the result is affected by NTP, so you could end up with negative durations. Bitronix was developed by Ludovic and Brett, and Brett has also switched to using nanoTime in HikariCP ( https://github.com/brettwooldridge/HikariCP/issues/215 ).

Frankly, I’m not aware of any nonoTime() issue. From all the source code I checked, it seems everyone is using it for durations. That’s why I asked you if you can provide more details about the nonoTime() problem you are worried about?

The only problem I’m now aware of is that, on some systems, if the OS does not support monotonic clocks, nanoTime will fall back to wall clock time, just like currentTimeMillis(). But, the major Operating Systems do support monotonic clocks.

( https://hibernate.atlassian.net/browse/HHH-13879#add-comment?atlOrigin=eyJpIjoiMThmODI2Nzc2ZWVhNDI5MTk3MTJhYjFkZTBkMGYzOWUiLCJwIjoiaiJ9 ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-13879#add-comment?atlOrigin=eyJpIjoiMThmODI2Nzc2ZWVhNDI5MTk3MTJhYjFkZTBkMGYzOWUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:a269fed )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/hibernate-issues/attachments/20200225/449f9cb3/attachment.html