[hibernate-issues] [JIRA] (HSEARCH-3839) Sorting by numeric value has an exception "(expected=NUMERIC). Use UninvertingReader or index with docvalues"

[Yoann Rodière (JIRA)]

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A58fa1ced-171a-4c00-97e8-5d70d442cc4b ) *commented* on HSEARCH-3839 ( https://hibernate.atlassian.net/browse/HSEARCH-3839?atlOrigin=eyJpIjoiMTQ2YzQxYTY0ZjgxNDAyY2I2NjRlZmI2Zjg1MTcyMTMiLCJwIjoiaiJ9 )

Re: Sorting by numeric value has an exception "(expected=NUMERIC). Use UninvertingReader or index with docvalues" ( https://hibernate.atlassian.net/browse/HSEARCH-3839?atlOrigin=eyJpIjoiMTQ2YzQxYTY0ZjgxNDAyY2I2NjRlZmI2Zjg1MTcyMTMiLCJwIjoiaiJ9 )

That was... fast! Thank you for taking the time to work on this.

The code looks a lot like Elasticsearch's code, so I suppose you took it from there and adapted it to our codebase? That's perfectly fine since their code is Apache 2 licensed, but we'll need to add notices to files that were copied from there, to preserve a "copyright trail". See for example org.hibernate.search.backend.lucene.lowlevel.docvalues.impl.NumericDoubleValues.

There are a few other things to iron out, like the code style and the tests that we need to add. I suspect we should also change the implementation of aggregations to use the sorted doc values instead of the old ones. Would you mind sending this patch as a pull request on Github so that we can discuss this and iterate? You can find a guide to sending pull requests in the CONTRIBUTING.md file ( https://github.com/hibernate/hibernate-search/blob/master/CONTRIBUTING.md ) ; don't hesitate to drop by the developer chat ( https://hibernate.zulipchat.com/#narrow/stream/132092-hibernate-search-dev ) if you need help.

( https://hibernate.atlassian.net/browse/HSEARCH-3839#add-comment?atlOrigin=eyJpIjoiMTQ2YzQxYTY0ZjgxNDAyY2I2NjRlZmI2Zjg1MTcyMTMiLCJwIjoiaiJ9 ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3839#add-comment?atlOrigin=eyJpIjoiMTQ2YzQxYTY0ZjgxNDAyY2I2NjRlZmI2Zjg1MTcyMTMiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:cefda43 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/hibernate-issues/attachments/20200226/dd0415a7/attachment.html