[hibernate-issues] [JIRA] (HHH-13926) StaleStateException should (optionally) not leak statements in the logs

[Sanne Grinovero (JIRA)]

Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A99e61e65-956b-4a21-b29c-06057642e9ea ) *commented* on HHH-13926 ( https://hibernate.atlassian.net/browse/HHH-13926?atlOrigin=eyJpIjoiYmYxZDhhMmEzZjgwNDE0N2E3ZGQ3MzhjMGMxYzY4ZjUiLCJwIjoiaiJ9 )

Re: StaleStateException should (optionally) not leak statements in the logs ( https://hibernate.atlassian.net/browse/HHH-13926?atlOrigin=eyJpIjoiYmYxZDhhMmEzZjgwNDE0N2E3ZGQ3MzhjMGMxYzY4ZjUiLCJwIjoiaiJ9 )

Thanks yes then I agree, we shouldn’t log the parameters. Looks like this was introduced as https://hibernate.atlassian.net/browse/HHH-12878.

I don’t think this should be based on the show_sql property though, that’s meant for a different aspect and it would be confusing to have it interact with this aspect.

I actually think we should never log parameters in the stacktrace of a {{StaleStateException}}so we could keep it simple and avoid any configuration property?

( https://hibernate.atlassian.net/browse/HHH-13926#add-comment?atlOrigin=eyJpIjoiYmYxZDhhMmEzZjgwNDE0N2E3ZGQ3MzhjMGMxYzY4ZjUiLCJwIjoiaiJ9 ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-13926#add-comment?atlOrigin=eyJpIjoiYmYxZDhhMmEzZjgwNDE0N2E3ZGQ3MzhjMGMxYzY4ZjUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100133- sha1:bf400b0 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/hibernate-issues/attachments/20200709/5685b4ef/attachment.html