[infinispan-commits] Infinispan SVN: r1371 - in trunk/cachestore/jdbc/src/main/java/org/infinispan/loaders/jdbc: stringbased and 1 other directory.

[infinispan-commits at lists.jboss.org]

Author: mircea.markus
Date: 2010-01-14 09:25:24 -0500 (Thu, 14 Jan 2010)
New Revision: 1371

Modified:
   trunk/cachestore/jdbc/src/main/java/org/infinispan/loaders/jdbc/binary/JdbcBinaryCacheStore.java
   trunk/cachestore/jdbc/src/main/java/org/infinispan/loaders/jdbc/stringbased/JdbcStringBasedCacheStore.java
Log:
updated JavaDoc

Modified: trunk/cachestore/jdbc/src/main/java/org/infinispan/loaders/jdbc/binary/JdbcBinaryCacheStore.java
===================================================================
--- trunk/cachestore/jdbc/src/main/java/org/infinispan/loaders/jdbc/binary/JdbcBinaryCacheStore.java	2010-01-14 13:31:48 UTC (rev 1370)
+++ trunk/cachestore/jdbc/src/main/java/org/infinispan/loaders/jdbc/binary/JdbcBinaryCacheStore.java	2010-01-14 14:25:24 UTC (rev 1371)
@@ -53,6 +53,10 @@
  * {@link BucketBasedCacheStore} implementation that will store all the buckets as rows in database, each row
  * corresponding to a bucket. This is in contrast to {@link org.infinispan.loaders.jdbc.stringbased.JdbcStringBasedCacheStore}
  * which stores each StoredEntry as a row in the database.
+ * </p>
+ * It is generally recommended to use {@link org.infinispan.loaders.jdbc.stringbased.JdbcStringBasedCacheStore} whenever
+ * possible as it performs better. Please read {@link org.infinispan.loaders.jdbc.stringbased.JdbcStringBasedCacheStore}'s
+ * javadoc for more details on this.
  * <p/>
  * This class has the benefit of being able to store StoredEntries that do not have String keys, at the cost of coarser
  * grained access granularity, and inherently performance.

Modified: trunk/cachestore/jdbc/src/main/java/org/infinispan/loaders/jdbc/stringbased/JdbcStringBasedCacheStore.java
===================================================================
--- trunk/cachestore/jdbc/src/main/java/org/infinispan/loaders/jdbc/stringbased/JdbcStringBasedCacheStore.java	2010-01-14 13:31:48 UTC (rev 1370)
+++ trunk/cachestore/jdbc/src/main/java/org/infinispan/loaders/jdbc/stringbased/JdbcStringBasedCacheStore.java	2010-01-14 14:25:24 UTC (rev 1371)
@@ -49,13 +49,18 @@
 /**
  * {@link org.infinispan.loaders.CacheStore} implementation that stores the entries in a database. In contrast to the
  * {@link org.infinispan.loaders.jdbc.binary.JdbcBinaryCacheStore}, this cache store will store each entry within a row
- * in the table (rather than grouping multiple entries into an row). This assures a finer graned granularity for all
+ * in the table (rather than grouping multiple entries into an row). This assures a finer grained granularity for all
  * operation, and better performance. In order to be able to store non-string keys, it relies on an {@link
  * Key2StringMapper}.
  * <p/>
  * The actual storage table is defined through configuration {@link JdbcStringBasedCacheStore}. The table can be
  * created/dropped on-the-fly, at deployment time. For more details consult javadoc for {@link
  * JdbcStringBasedCacheStore}.
+ * <p/>
+ * It is recommeneded to use {@link org.infinispan.loaders.jdbc.stringbased.JdbcStringBasedCacheStore}} over
+ * {@link org.infinispan.loaders.jdbc.binary.JdbcBinaryCacheStore}} whenever it is possible, as is has a better performance.
+ * One scenario in which this is not possible to use it though, is when you can't write an {@link Key2StringMapper}} to map the
+ * keys to to string objects (e.g. when you don't have control over the types of the keys, for whatever reason).
  *
  * @author Mircea.Markus at jboss.com
  * @see Key2StringMapper