[infinispan-dev] keySet(), values() and entrySet() not implemented

[Manik Surtani]

On 4 Jun 2009, at 10:20, Galder Zamarreno wrote:

>
>
> Manik Surtani wrote:
>> +1.
>> Implementing these naively is easy; anything else is much harder.   
>> Here are some basic thoughts.
>> If we are in LOCAL or REPL mode, this is straightforward *if* we  
>> ignore cache stores.  If we take cache stores or DIST into account,  
>> we have the potential for instant OOMs.  Even if we use custom  
>> collections that load lazily from a store or across a cluster, the  
>> collections still need to efficiently handle contains(), size(), etc.
>> Perhaps we should just limit these to reporting what is local, and  
>> in-memory only.  Clearly Javadoc'ed, of course, to detail these  
>> limitations - along with a general recommendation that these are  
>> inherited from ConcurrentMap and not expected to be used in any  
>> extensive or meaningful way.
>
> +1. I like the idea of only reporting what's available locally +  
> documenting it correctly.
>
>> A few other thoughts (and these should be javadoc'ed too):
>> * These collections should always be immutable
>> * These methods do not participate in any transactions
>
> +1 to both.
>
> I volunteer to implement this unless someone else wants to do it?

Sure, all yours!

Cheers
--
Manik Surtani
manik at jboss.org
Lead, Infinispan
Lead, JBoss Cache
http://www.infinispan.org
http://www.jbosscache.org