[infinispan-dev] StateTransferControlCommand initialisation?

Manik Surtani manik at jboss.org
Fri Mar 27 07:00:23 EDT 2009


On 27 Mar 2009, at 10:47, Galder Zamarreno wrote:

>>
>> No.  The RPCManager is scoped as GLOBAL:
>>    https://svn.jboss.org/repos/infinispan/trunk/src/main/java/org/infinispan/remoting/RPCManager.java 
>>  Refer to the @Scope annotation on the interface.
>> But I understand your confusion here.  We should either:
>> 1.  Change the Javadocs on fromStream() to be more explicit, i.e.,  
>> only dependent components of GLOBAL scope are injected. NAMED_CACHE  
>> scope components are only injected later with  
>> CommandsFactory.initializeReplicableCommand().
>> 2.  Remove the injection in fromStream(); have  
>> CommandsFactory.initializeReplicableCommand() handle all of the  
>> injection, of GLOBAL and NAMED_CACHE scoped components.
>> I have no problem with 2, if it makes your integration easier.  In  
>> fact, I actually think 2 is probably cleaner.
>
> Yeah, 2 would be perfect for me. I can implement 2 and run the full  
> testsuite and see whether all works fine.
>
> If it looks good, I'll create a JIRA so that we keep a separate  
> track of this change.

+1

--
Manik Surtani
Lead, JBoss Cache
http://www.jbosscache.org
manik at jboss.org




-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/infinispan-dev/attachments/20090327/55bd8bdb/attachment-0001.html 


More information about the infinispan-dev mailing list