[infinispan-dev] Committing Infinispan log4j.xml with TRACE

[Manik Surtani]

I was going to say, log4j.xml is supposed to be in version control and is supposed to be legitimately modified and changed periodically to make sure we ship a sensible default.  Galder's point is just that we shouldn't:

a) modify it to be more verbose for local test runs, and then
b) unintentionally check it in!


On 12 Nov 2009, at 09:23, Galder Zamarreno wrote:

> I suppose you could but then if we wanna make changes to the actual 
> log4j.xml shipped, we wouldn't be able to keep track of those changes, 
> couldn't we?
> 
> On 11/11/2009 10:11 PM, Jimmy Wilson wrote:
>> Wouldn't svn:ignore be best as it prevents you from doing this regardless?
>> 
>> Jimmy
>> 
>> Manik Surtani wrote:
>>> Good idea, Galder.
>>> 
>>> On 11 Nov 2009, at 10:40, Sanne Grinovero wrote:
>>> 
>>>> nice trick! thanks for that.
>>>> 
>>>> 2009/11/11 Galder Zamarreno<galder at redhat.com>:
>>>>> Hi,
>>>>> 
>>>>> It seems like we've committed src/test/resources/log4j.xml with TRACE
>>>>> logging to Infinispan a couple of times already:
>>>>> 
>>>>> http://fisheye.jboss.org/browse/Infinispan/trunk/core/src/test/resources/log4j.xml?r1=893&r2=1115
>>>>> http://fisheye.jboss.org/browse/Infinispan/trunk/core/src/test/resources/log4j.xml?r1=347&r2=891
>>>>> 
>>>>> This is leaking to Infinispan binary distribution, so be careful about
>>>>> doing this. Personally, I never touch this file and instead pass my own
>>>>> log4j.xml to the tests via:
>>>>> 
>>>>> -Dlog4j.configuration=file:/home/galder/jboss/others/logging/log4j/log4j-infinispan.xml
>>>>> 
>>>>> That way I never run the risk of leaving the log4j in SVN with the wrong
>>>>> logging levels.
>>>>> 
>>>>> Cheers,
>>>>> --
>>>>> Galder Zamarreño
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
> 
> -- 
> Galder Zamarreño
> Sr. Software Engineer
> Infinispan, JBoss Cache
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev

--
Manik Surtani
manik at jboss.org
Lead, Infinispan
Lead, JBoss Cache
http://www.infinispan.org
http://www.jbosscache.org