[infinispan-dev] Test cleanup

[Manik Surtani]

On 15 Sep 2009, at 20:02, Mircea Markus wrote:

>
> On Sep 15, 2009, at 6:16 PM, Vladimir Blagojevic wrote:
>
>> Hey guys,
>>
>> I do not know the details behind the decision to run cleanup after
>> each
>> test method in all subclasses of MultipleCacheManagersTest but the
>> consequence is that the testsuite execution is indeed really slow.
> the killing of jgroups instance is performed *only* if cleanup phase
> is set to CleanupPhase.AFTER_METHOD. Otherwise/default the cache
> managers are only being cleaned between test methods.Default is set to
> CleanupPhase.AFTER_TEST, which means that the same cache managers are
> being reused through tests. Can you please check weather you aren't
> looking at an CleanupPhase.AFTER_METHOD test?

Yeah some tests are a bit more finicky and require a proper cleanup  
between methods, but the default should be CleanupPhase.AFTER_TEST.



>> After
>> each test method execution we are killing JGroups instances and then
>> recreating at least two of them who then have to find each other,
>> join,
>> create a cluster before the next test method can be run again.
>>
>> There is no reason why we cannot run a check after each test method  
>> to
>> ensure that cache instance are totally pristine and in the case the
>> are
>> not we can kill them and only then recreate cluster.
>>
>> Cheers
>>
>>
>>
>>
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev

--
Manik Surtani
manik at jboss.org
Lead, Infinispan
Lead, JBoss Cache
http://www.infinispan.org
http://www.jbosscache.org