[infinispan-dev] Changing managed method names

[Manik Surtani]

Galder's right, please consider any method or field annotated with @ManagedAttribute/Operation or any JOPR annotation as *public* API, even if it is on a non-public class.  As such, please treat any such method/field with all the consideration you would offer to any other public API (such as a method on org.infinispan.Cache) and discuss any changes here first.

Cheers
Manik

On 6 Jul 2010, at 09:17, Mircea Markus wrote:

> 
> On 6 Jul 2010, at 10:41, Galder Zamarreño wrote:
> 
>> Hey,
>> 
>> As a result of changing RpcManagerImpl getAddress method name to getNodeAddress, the following test is failing:
>> 
>> http://hudson.qa.jboss.com/hudson/view/Infinispan/job/Infinispan-4.1.x-JDK6-tcp/org.infinispan$infinispan-core/4/testReport/junit/org.infinispan.jmx/RpcManagerMBeanTest-testAddressInformation/org_infinispan_jmx_RpcManagerMBeanTest_testAddressInformation/
>> 
>> Be careful about changing method names, particularly when these methods are annotated with @ManagedAttribute or JOPR annotations because they affect statistic MBean property names.
> ok, thanks
>> 
>> By the way, what is the reason why you changed the method name and added a new getAddress method to RpcManager interface and RpcManagerImpl?
>> 
>> That information is available via rpcManager.getTransport.getAddress. Is it to provide some kind of shortcut?
> yes
>> DefaultCacheManager uses transport.getAddress() without problems. 
>> 
>> Cheers,
>> --
>> Galder Zamarreño
>> Sr. Software Engineer
>> Infinispan, JBoss Cache
>> 
> 
> 
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev

--
Manik Surtani
manik at jboss.org
Lead, Infinispan
Lead, JBoss Cache
http://www.infinispan.org
http://www.jbosscache.org