[infinispan-dev] ISPN-232 - feedback needed

[Mircea Markus]

On 24 May 2010, at 14:10, Manik Surtani wrote:

> Hi there
> 
> * Do you have an example usage?  I presume the entry point here is the KeyAffinityServiceFactory?  Perhaps some usage examples in the KeyAffinityServiceFactory javadoc would be best, both for now and in future to document the API.
added sample usage in KeyAffinityService together with some other aspects.
> 
> * KeyAffinityService.getCollocatedKey() -> KeyAffinityService.getColocatedKey() (typo)
The bundled IDEA speller (I'm not able to configure a locale for it) sees "collocated" as the right spelling. Also the "New English American Dictionary" on my mac book only recognises "collocated". Is this some of UK/US difference in spelling?    
> * KeyAffinityService usage examples?  Again best if this is in Javadoc
added
> * Perhaps KeyGenerator is a better name for KeyProvider?  Since keys are, in fact, generated rather than retrieved from elsewhere/looked up
+1
> * KeyProvider/KeyGenerator to be parameterized with <K> as well?
+1
> * Methods on interfaces don't need "public". :)  [1]
live and learn :)
> 
> Cheers
> Manik
> 
> [1] http://java.sun.com/docs/books/jls/third_edition/html/interfaces.html#9.4 - "It is permitted, but strongly discouraged as a matter of style, to redundantly specify the public modifier for interface methods."
> 
> On 24 May 2010, at 11:15, Mircea Markus wrote:
> 
>> Hi,
>> 
>> I've committed[1] the interfaces for the key-affinity service in ISPN-232.
>> Would you mind taking a look and let me know what you think?
>> 
>> Thanks!
>> Mircea
>> 
>> [1] http://anonsvn.jboss.org/repos/infinispan/trunk/core/src/main/java/org/infinispan/affinity/
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
> 
> --
> Manik Surtani
> manik at jboss.org
> Lead, Infinispan
> Lead, JBoss Cache
> http://www.infinispan.org
> http://www.jbosscache.org
> 
> 
> 
> 
> 
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev