[infinispan-dev] TableManipulation refactoring

[Galder Zamarreño]

On Oct 12, 2010, at 6:27 PM, Elias Ross wrote:

> It'd be interesting if Infinispan simply could use directly (or
> repackage) the Hibernate dialects as-is for the JDBC cache store. It
> might save some time.

I think Elias has a very good point here, can we consume Hibernate's dialects directly instead of reimplementing the same logic again?

Bringing hibernate-core might be too much but if dialect classes can be consumed separately, we could maybe suggest the hibernate guys to separate them into a diff module.

> 
> On Tue, Oct 12, 2010 at 8:57 AM, "이희승 (Trustin Lee)" <trustin at gmail.com> wrote:
>> There are two on-going issues related with TableManipulation at the moment:
>> 
>>    https://jira.jboss.org/browse/ISPN-686
>>    https://jira.jboss.org/browse/ISPN-698
>> 
>> They both are related with vendor specific behavior, and the current
>> implementation uses switch-cases to deal with the differences between
>> vendors.  Could we instead use inheritance to make the code look cleaner
>> and easier to maintain?  Hibernate does so:
>> 
>> 
>> http://viewvc.jboss.org/cgi-bin/viewvc.cgi/hibernate/core/trunk/core/src/main/java/org/hibernate/dialect/
>> 
>> Also, the properties like custom types, names, prefixes, fetch/batch
>> sizes could be moved to AbstractJdbcCacheStoreConfig (or its subclass
>> because we have mixed JDBC store) instead of exposing TableManipulation
>> directly to a user?
>> 
>> --
>> http://gleamynode.net/
>> 
>> 
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>> 
> 
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev

--
Galder Zamarreño
Sr. Software Engineer
Infinispan, JBoss Cache