[infinispan-dev] exceptions and locking policy

[Manik Surtani]

On 6 Sep 2010, at 14:39, Mircea Markus wrote:

> 
> On 6 Sep 2010, at 14:33, Manik Surtani wrote:
> 
>> 
>> On 6 Sep 2010, at 14:28, Mircea Markus wrote:
>> 
>>>> I notice you've ripped this logic out of the InvocationContextInterceptor in branches/4.2.x
>>>> 
>>>> http://fisheye.jboss.org/browse/Infinispan/branches/4.2.x/core/src/main/java/org/infinispan/interceptors/InvocationContextInterceptor.java?r1=2273&r2=2323&u=3#l45
>>>> 
>>>> Note that this is incorrect since, as I pointed out, you will miss exceptions thrown between the InvocationContextInterceptor and the LockingInterceptor.
>>> This code was committed before this discussion to take place. I needed it in because couldn't work on DLD without it). 
>>> It wil be addressed in  ISPN-629
>> 
>> Ok, just be careful when rolling it back/reimplementing - it's tricky stuff.  A few extra tests around it would be a good idea as well.  :)
> Of course- that's why I added these [1] before making the changes :) 
> [1] http://fisheye.jboss.org/browse/Infinispan/branches/4.2.x/core/src/test/java/org/infinispan/tx/timeout

Good stuff.  Add a test that causes an interceptor between the InvocationContextInterceptor and the LockingInterceptor to throw an exception as well.

--
Manik Surtani
manik at jboss.org
Lead, Infinispan
Lead, JBoss Cache
http://www.infinispan.org
http://www.jbosscache.org