[infinispan-dev] CacheDelegate.lock() strangely differing between trunk and 4.2.x

[Manik Surtani]

Guys if we have closed JIRAs in 4.2.x we *must* apply these to trunk as well.  This is just the start of the kind of problems we're going to experience if we don't stick to this simple rule.

On 15 Sep 2010, at 10:43, Galder Zamarreño wrote:

> Hi Mircea,
> 
> There's something that's causing me issues in the CacheDelegate code. There're some differences between trunk and 4.2.x which I don't understand:
> 
> In trunk you find:
> 
>   public void lock(K key) {
>      assertKeyNotNull(key);
>      //this will be removed with https://jira.jboss.org/browse/ISPN-598 
>      ConfigurationValidatingVisitor.checkEagerLockingAndDld(config, true);
>      lock(Collections.singletonList(key));
>   }
> 
> And in 4.2.x:
> 
>   public void lock(K key) {
>      assertKeyNotNull(key);
>      lock(Collections.singletonList(key));
>   }
> 
> First of all, that comment about https://jira.jboss.org/browse/ISPN-598 is probably mixed up. I think it refers to https://jira.jboss.org/browse/ISPN-589 instead.
> 
> Now, https://jira.jboss.org/browse/ISPN-589 has already been fixed. So, are those two lines some leftover due to merge mixup? Or do they really make sense to be there?
> 
> The reason this is causing me issues is due to a patch I was trying to apply in trunk wrt https://jira.jboss.org/browse/ISPN-649.
> 
> Cheers,
> --
> Galder Zamarreño
> Sr. Software Engineer
> Infinispan, JBoss Cache
> 
> 
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev

--
Manik Surtani
manik at jboss.org
Lead, Infinispan
Lead, JBoss Cache
http://www.infinispan.org
http://www.jbosscache.org