[infinispan-dev] cache name in logs

[Manik Surtani]

I think any log attached to a named cache component (versus a global component) should present cache name.

On 29 Apr 2011, at 12:48, Mircea Markus wrote:

> 
> On 29 Apr 2011, at 16:37, Manik Surtani wrote:
> 
>> My vote is to go with the MDC approach.
> +1
> I will create a JIRA for this. Before that just want to ask which other components than Distribution manager would benefit from this approach? I'm thinking about:
> DsitributionManagerImpl
> TransactionTable (it also reacts to view changes, so multiple caches on the same CM would create confusing logs)...
> Other?
> 
> Or would it be a good idea to have it for ALL the the logs in we output? After it doesn't make a lot of noise...
> 
> Cheers,
> Mircea
> 
>> 
>> On 29 Apr 2011, at 11:33, Mircea Markus wrote:
>> 
>>> 
>>> On 29 Apr 2011, at 16:26, Olaf Bergner wrote:
>>> 
>>>> Am 29.04.11 16:55, schrieb Galder Zamarreño:
>>>>> On Apr 28, 2011, at 11:47 PM, Manik Surtani wrote:
>>>>> 
>>>>>> We do now support JBoss Logging.
>>>>>> 
>>>>>> https://issues.jboss.org/browse/ISPN-380
>>>>>> 
>>>>>> @Galder, does JBoss Logging have support for what Mircea mentioned below?
>>>>> I've skimmed through the javadoc but didn't see anything in particular for this at least around the message loggers which are the ones that help with internationalization.
>>>>> 
>>>>> I think it could be fitted but would require a fair amount of changes, such as making some static loggers, particularly those for named cache components non static in order to take the cache name. Maybe you could have a named cache component for a log factory?
>>>> A workaround that IMHO feels a little hackish though would be to simply 
>>>> append the current cache's name to the class name when instantiating a 
>>>> logger:
>>>> 
>>>> logger = LoggerFactory.getLogger(getClass().getName() + "[cache = " + 
>>>> cacheName + "]")
>>>> 
>>>> I wouldn't recommend this.
>>> That would also require having a logger/class instance, and not make the logger  static. For my scenario (DisttributionManagerImpl) that might work as there's a single DisttributionManagerImpl per Cache.
>>> Besides not being able to make the logger static. any other reasons for not going with this approach? 
>>> _______________________________________________
>>> infinispan-dev mailing list
>>> infinispan-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>> 
>> --
>> Manik Surtani
>> manik at jboss.org
>> twitter.com/maniksurtani
>> 
>> Lead, Infinispan
>> http://www.infinispan.org
>> 
>> 
>> 
>> 
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
> 
> 
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev

--
Manik Surtani
manik at jboss.org
twitter.com/maniksurtani

Lead, Infinispan
http://www.infinispan.org