[infinispan-dev] Grid Filesystem

[Bela Ban]

Excellent !

GridFS needed a lot of work, so kudos for picking this up.

A +1 on the points you brought up at the end of your email.

GridFS is a great tool to stress Infinispan, so I hope we can come up 
with a better demo than the one I created (using webdav to access the 
file system from clients)... Perhaps an implementation of fuse ?


On 1/3/12 2:55 PM, Marko Lukša wrote:
> Hey guys.
>
> Aleš Justin and I will be using infinispan's grid file system for Capedwarf.
>
> I have fixed a few issues in GFS. Before I issue a pull request, I need
> to know if you guys prefer a single commit for all of them or separate
> commits. What about jira issues - separate or one single jira issue?
>
> Here's a list of my commits:
>
> - Implement appending to files (up to now, the append parameter was ignored)
> - Implement GridFile.getParent() and getParentFile()
> - Implement GridFile.lastModified()
> - Prevent writing to and reading from directories
> - Fix bugs related to non-default chunk size
> - Leak when overwriting existing file with shorter content length
> (excess file chunks are never removed from cache)
> - Leak when calling GridFile.delete() (removes only file metadata, but
> not the actual file contents)
> - GridFile.createNewFile() does not honor the contract of
> File.createNewFile()
> - GridFile.list() does not honor contract of File.list() and also has a
> few bugs (it doesn't handle file separators correctly)
> - GridFilesystem.getFile(File, String) creates File with illegal path
> (on windows, the created file begins with "C:\...")
> - mkdir() fails on "/dir", but works on "dir"
> - the root dir is not handled properly
> - add javadoc to GridFilesystem
>
>
> There are also a few other things. Before I fix them, I would like you
> to confirm my thinking is correct:
>
> - GFS.getFile("/hello.txt") should point to the same file as
> GFS.getFile("hello.txt"), but it currently does not. GFS treats these
> two as two distinct files.
> - GridFilesystem.remove() shouldn't be public, because the proper way to
> remove files is through GridFile.delete(). By calling
> GridFilesystem.remove(), only the file's contents are removed, but the
> metadata is not).
> - GridFile.setLength() should throw an exception instead of printing to
> System.err

-- 
Bela Ban
Lead JGroups (http://www.jgroups.org)
JBoss / Red Hat