[infinispan-dev] ISPN-2463: RecoveryWithDefaultCacheDistTest
Adrian Nistor
anistor at redhat.com
Thu Nov 15 09:05:39 EST 2012
I've seen such meaningless code in many other places and turned them
into asserts. Please do so instead of removing them.
On 11/15/2012 11:13 AM, Dan Berindei wrote:
>
> I'm guessing the author's intention was to make them both asserts.
>
> În data de 15.11.2012 07:35, "Navin Surtani" <nsurtani at redhat.com
> <mailto:nsurtani at redhat.com>> a scris:
>
> I noticed a couple of unused returns in the test class mentioned
> in the subject. The specific code lines can be found here [1].
>
> If there aren't any objections I'm going to remove these calls as
> I can't see why that code is there. The returned boolean type
> isn't being used for any checks. Well, it's not being used at all. :-)
>
> Thanks!
>
> ------------------------
> Navin Surtani
>
>
> Software Engineer
> JBoss SET
> JBoss EAP
>
>
> Twitter: @navssurtani
>
> [1] -
> https://github.com/infinispan/infinispan/blob/master/core/src/test/java/org/infinispan/tx/recovery/RecoveryWithDefaultCacheDistTest.java#L61
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org <mailto:infinispan-dev at lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
>
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/infinispan-dev/attachments/20121115/38a18938/attachment.html
More information about the infinispan-dev
mailing list