[infinispan-dev] Testsuite: hanging TestNG, CDI proken

[Galder Zamarreño]

On Oct 29, 2012, at 8:59 AM, Anna Manukyan <amanukya at redhat.com> wrote:

> Hi Sanne,
> 
> sorry for my interfering in - I was lately working on CDI testsuite - evaluating the coverage, etc. and actually on my local environment as well as on Jenkins, the CDI integration tests are passing properly.
> 
> I've run the tests several times, but I hadn't got the test hangouts as you have mentioned and all tests are passing on my side without failures.
> 
> I've tried also the testsuite execution with TestNG version 6.7 and it is fine as well.
> 
> I just thought, maybe there is something wrong with your testsuite setup or environment (just thoughts)?

We've seen CDI testsuite fail massively at points due to some bug in TestNG, and although I cannot find the exact email right now, I thought long term the idea was to move to JUnit.

Example: https://infinispan.ci.cloudbees.com/job/Infinispan-master-JDK6-tcp/867/#showFailuresLink

@Sanne, if you see tests failing (apart from the massive CDI failure thing, if it looks like the failures in the link above), create a JIRA and assign it to the right person. The problem is disabling the tests which is a bit tedious if you're doing per JIRA, but you could batch them up.

> 
> Best regards,
> Anna.
> 
> ----- Original Message -----
> From: "Sanne Grinovero" <sanne at infinispan.org>
> To: "infinispan -Dev List" <infinispan-dev at lists.jboss.org>
> Sent: Sunday, October 28, 2012 11:12:32 AM
> Subject: [infinispan-dev] Testsuite: hanging TestNG, CDI proken
> 
> Hello all,
> 
> besides having regular failures, I also experienced occasional hangs
> while running the testsuite; in some cases I found the following stack
> which suggests a TestNG bug:
> 
> "pool-3-thread-14" prio=10 tid=0x00007f0d84632000 nid=0x1ce5 runnable
> [0x00007f0d58a36000]
>   java.lang.Thread.State: RUNNABLE
> 	at java.util.HashMap.put(HashMap.java:374)
> 	at org.testng.SuiteRunner.runTest(SuiteRunner.java:320)
> 	at org.testng.SuiteRunner.access$000(SuiteRunner.java:34)
> 	at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:351)
> 	at org.testng.internal.thread.ThreadUtil$CountDownLatchedRunnable.run(ThreadUtil.java:147)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> 	at java.lang.Thread.run(Thread.java:662)
> 
> Even when taking multiple dumps that thread is still in the same loop,
> and having a single CPU stuck at 100% I'm guessing the HashMap was
> being used in some unsafe way regarding concurrency; we're using the
> first minor version of TestNG which ever supported parallel testsuite
> invocations so that might not be very solid.
> 
> Not sure why, but upgrading TestNG from 5.14.10 to 6.7 seems to
> resolve the problem.
> 
> Now I wish I could send a pull request, but even skipping just the
> core testsuite (which always fails for me even in non-parallel mode)
> many other modules are broken both with and without my patches, so I'm
> dropping my experiments as I won't send any pull requests if the tests
> can't back my changes up.
> 
> As an example the CDI integration is:
> 
> Tests run: 247, Failures: 102, Errors: 0, Skipped: 143
> 
> ...which means 2 tests are fine.
> 
> Cheers,
> Sanne
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev


--
Galder Zamarreño
galder at redhat.com
twitter.com/galderz

Project Lead, Escalante
http://escalante.io

Engineer, Infinispan
http://infinispan.org