[infinispan-dev] Testsuite: hanging TestNG, CDI proken

Manik Surtani manik at jboss.org
Mon Oct 29 13:12:13 EDT 2012 

Ok, I've hijacked http://issues.jboss.org/browse/ISPN-2450 and have issued https://github.com/infinispan/infinispan/pull/1434

The pull request is for master.  I think it should be applied to branch 5.1.x as well, but I'll let one of you guys test it on 5.1.x first - I have a flight to catch.  :)

- M

On 29 Oct 2012, at 16:51, Mircea Markus <mircea.markus at jboss.com> wrote:

> 
> On 29 Oct 2012, at 15:25, Manik Surtani wrote:
> 
>> For what it's worth, I just created a branch with:
>> 
>> * TestNG 6.7 as a dependency in parent/pom.xml (so all modules use this)
>> * Updated cdi/extension/pom.xml to use ${version.testng} rather than ${version.testng.arquillian} - so it too now uses TestNG 6.7.
>> 
>> Ran tests.
>> 
>> Results from tests in cdi/extension:
>> 
>> Results :
>> 
>> Tests run: 60, Failures: 0, Errors: 0, Skipped: 0
>> 
>> Anyone want a pull req? ;)
>> 
> 
> I do :)
>> - M
>> 
>> On 29 Oct 2012, at 16:06, Sanne Grinovero <sanne at infinispan.org> wrote:
>> 
>>> On 29 October 2012 08:59, Anna Manukyan <amanukya at redhat.com> wrote:
>>>> Hi Sanne,
>>>> 
>>>> sorry for my interfering in - I was lately working on CDI testsuite - evaluating the coverage, etc. and actually on my local environment as well as on Jenkins, the CDI integration tests are passing properly.
>>> 
>>> Hi Anna,
>>> I wouldn't call that interfering, it's exactly the kind of feedback I
>>> was looking for. I just checked master again, and it still failed for
>>> me.
>>> This is the stack I have in all tests, in case it helps:
>>> 
>>> java.lang.NullPointerException
>>> 	at org.jboss.arquillian.testng.Arquillian.arquillianAfterClass(Arquillian.java:82)
>>> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>>> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>>> 	at java.lang.reflect.Method.invoke(Method.java:597)
>>> 	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:74)
>>> 	at org.testng.internal.Invoker.invokeConfigurationMethod(Invoker.java:525)
>>> 	at org.testng.internal.Invoker.invokeConfigurations(Invoker.java:202)
>>> 	at org.testng.internal.Invoker.invokeConfigurations(Invoker.java:130)
>>> 	at org.testng.internal.TestMethodWorker.invokeAfterClassMethods(TestMethodWorker.java:222)
>>> 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
>>> 	at org.testng.TestRunner.runWorkers(TestRunner.java:1147)
>>> 	at org.testng.TestRunner.privateRun(TestRunner.java:749)
>>> 	at org.testng.TestRunner.run(TestRunner.java:600)
>>> 	at org.testng.SuiteRunner.runTest(SuiteRunner.java:317)
>>> 	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:312)
>>> 	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:274)
>>> 	at org.testng.SuiteRunner.run(SuiteRunner.java:223)
>>> 	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
>>> 	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
>>> 	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1039)
>>> 	at org.testng.TestNG.runSuitesLocally(TestNG.java:964)
>>> 	at org.testng.TestNG.run(TestNG.java:900)
>>> 	at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:77)
>>> 
>>> 
>>> Anyway, whatever the state of CDI that looks like a separate problem;
>>> I can't run the core testsuite reliably with this version of TestNG;
>>> from Vladimir's comment I guess we can't upgrade easily
>>> so I'm opening ISPN-2450.
>>> 
>>> Cheers,
>>> Sanne
>>> 
>>> 
>>>> 
>>>> I've run the tests several times, but I hadn't got the test hangouts as you have mentioned and all tests are passing on my side without failures.
>>>> 
>>>> I've tried also the testsuite execution with TestNG version 6.7 and it is fine as well.
>>>> 
>>>> I just thought, maybe there is something wrong with your testsuite setup or environment (just thoughts)?
>>>> 
>>>> Best regards,
>>>> Anna.
>>>> 
>>>> ----- Original Message -----
>>>> From: "Sanne Grinovero" <sanne at infinispan.org>
>>>> To: "infinispan -Dev List" <infinispan-dev at lists.jboss.org>
>>>> Sent: Sunday, October 28, 2012 11:12:32 AM
>>>> Subject: [infinispan-dev] Testsuite: hanging TestNG, CDI proken
>>>> 
>>>> Hello all,
>>>> 
>>>> besides having regular failures, I also experienced occasional hangs
>>>> while running the testsuite; in some cases I found the following stack
>>>> which suggests a TestNG bug:
>>>> 
>>>> "pool-3-thread-14" prio=10 tid=0x00007f0d84632000 nid=0x1ce5 runnable
>>>> [0x00007f0d58a36000]
>>>>  java.lang.Thread.State: RUNNABLE
>>>>       at java.util.HashMap.put(HashMap.java:374)
>>>>       at org.testng.SuiteRunner.runTest(SuiteRunner.java:320)
>>>>       at org.testng.SuiteRunner.access$000(SuiteRunner.java:34)
>>>>       at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:351)
>>>>       at org.testng.internal.thread.ThreadUtil$CountDownLatchedRunnable.run(ThreadUtil.java:147)
>>>>       at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
>>>>       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
>>>>       at java.lang.Thread.run(Thread.java:662)
>>>> 
>>>> Even when taking multiple dumps that thread is still in the same loop,
>>>> and having a single CPU stuck at 100% I'm guessing the HashMap was
>>>> being used in some unsafe way regarding concurrency; we're using the
>>>> first minor version of TestNG which ever supported parallel testsuite
>>>> invocations so that might not be very solid.
>>>> 
>>>> Not sure why, but upgrading TestNG from 5.14.10 to 6.7 seems to
>>>> resolve the problem.
>>>> 
>>>> Now I wish I could send a pull request, but even skipping just the
>>>> core testsuite (which always fails for me even in non-parallel mode)
>>>> many other modules are broken both with and without my patches, so I'm
>>>> dropping my experiments as I won't send any pull requests if the tests
>>>> can't back my changes up.
>>>> 
>>>> As an example the CDI integration is:
>>>> 
>>>> Tests run: 247, Failures: 102, Errors: 0, Skipped: 143
>>>> 
>>>> ...which means 2 tests are fine.
>>>> 
>>>> Cheers,
>>>> Sanne
>>>> _______________________________________________
>>>> infinispan-dev mailing list
>>>> infinispan-dev at lists.jboss.org
>>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>>>> _______________________________________________
>>>> infinispan-dev mailing list
>>>> infinispan-dev at lists.jboss.org
>>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>>> _______________________________________________
>>> infinispan-dev mailing list
>>> infinispan-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>> 
>> --
>> Manik Surtani
>> manik at jboss.org
>> twitter.com/maniksurtani
>> 
>> Platform Architect, JBoss Data Grid
>> http://red.ht/data-grid
>> 
>> 
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
> 
> Cheers,
> -- 
> Mircea Markus
> Infinispan lead (www.infinispan.org)
> 
> 
> 
> 
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev

--
Manik Surtani
manik at jboss.org
twitter.com/maniksurtani

Platform Architect, JBoss Data Grid
http://red.ht/data-grid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/infinispan-dev/attachments/20121029/fca45d37/attachment-0001.html

More information about the infinispan-dev mailing list