[infinispan-dev] Hot Rod Remote Events #3: Customizing events

[Emmanuel Bernard]

I think you should pass the event type as enum as well. It is essentially free in memory and bits on the wire and avoids confusing guesses involving old/new value comparison with null to guess the event and transition happening. 


> On 22 sept. 2014, at 19:38, William Burns <mudokonman at gmail.com> wrote:
> 
> Talking with Mircea we are thinking that the least confusing way of
> implementing this is to instead just change the KeyValueFilter and
> Converter interfaces to instead have an additional parameter of
> oldValue passed along in addition to the others.  Unfortunately some
> uses of these interfaces does not fully make sense, especially outside
> of events, but in those cases we will always pass a null oldValue and
> I will update the other methods to reflect this.  Such cases are
> cluster entry iterator and data container iteration.
> 
> Any objections or thoughts?