[infinispan-dev] WFLYTX0013 in the Infinispan Openshift Template

[Radoslav Husar]

Hi Sebastian,

On Wed, Apr 11, 2018 at 2:31 PM, Sebastian Laskawiec
<slaskawi at redhat.com> wrote:
> Hey Rado, Paul,
>
> I started looking into this issue and it turned out that WF subsystem
> template doesn't provide `node-identifier` attribute [1].

I assume you mean that the default WildFly server profiles do not
explicitly define the attribute. Right – thus the value defaults in
the model to "1"
https://github.com/wildfly/wildfly/blob/master/transactions/src/main/java/org/jboss/as/txn/subsystem/TransactionSubsystemRootResourceDefinition.java#L97
which sole intention seems to be to log a warning on boot if the value
is unchanged.
Why they decided on a constant that will be inherently not unique as
opposed to defaulting to the node name (which we already require to be
unique) as clustering node name or undertow instance-id does, is
unclear to me.
Some context is on https://issues.jboss.org/browse/WFLY-1119.

> I'm not sure if you guys are the right people to ask, but is it safe to
> leave it set to default? Or shall I override our Infinispan templates and
> add this parameter (as I mentioned before, in OpenShift this I wanted to set
> it as Pod name trimmed to the last 23 chars since this is the limit).

It is not safe to leave it set to "1" as that results in inconsistent
processing of transaction recovery.
IIUC we already set it to the node name for both EAP and JDG
https://github.com/jboss-openshift/cct_module/blob/master/os-eap70-openshift/added/standalone-openshift.xml#L411
https://github.com/jboss-openshift/cct_module/blob/master/os-jdg7-conffiles/added/clustered-openshift.xml#L282
which in turn defaults to the pod name – so which profiles are we
talking about here?

Rado

> Thanks,
> Seb
>
> [1] usually set to node-identifier="${jboss.node.name}"
>
>
> On Mon, Apr 9, 2018 at 10:39 AM Sanne Grinovero <sanne at infinispan.org>
> wrote:
>>
>> On 9 April 2018 at 09:26, Sebastian Laskawiec <slaskawi at redhat.com> wrote:
>> > Thanks for looking into it Sanne. Of course, we should add it (it can be
>> > set
>> > to the same name as hostname since those are unique in Kubernetes).
>> >
>> > Created https://issues.jboss.org/browse/ISPN-9051 for it.
>> >
>> > Thanks again!
>> > Seb
>>
>> Thanks Sebastian!
>>
>> >
>> > On Fri, Apr 6, 2018 at 8:53 PM Sanne Grinovero <sanne at infinispan.org>
>> > wrote:
>> >>
>> >> Hi all,
>> >>
>> >> I've started to use the Infinispan Openshift Template and was browsing
>> >> through the errors and warnings this produces.
>> >>
>> >> In particular I noticed "WFLYTX0013: Node identifier property is set
>> >> to the default value. Please make sure it is unique." being produced
>> >> by the transaction system.
>> >>
>> >> The node id is usually not needed for developer's convenience and
>> >> assuming there's a single node in "dev mode", yet clearly the
>> >> Infinispan template is meant to work with multiple nodes running so
>> >> this warning seems concerning.
>> >>
>> >> I'm not sure what the impact is on the transaction manager so I asked
>> >> on the Narayana forums; Tom pointed me to some thourough design
>> >> documents and also suggested the EAP image does set the node
>> >> identifier:
>> >>  - https://developer.jboss.org/message/981702#981702
>> >>
>> >> WDYT? we probably want the Infinispan template to set this as well, or
>> >> silence the warning?
>> >>
>> >> Thanks,
>> >> Sanne
>> >> _______________________________________________
>> >> infinispan-dev mailing list
>> >> infinispan-dev at lists.jboss.org
>> >> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>> >
>> >
>> > _______________________________________________
>> > infinispan-dev mailing list
>> > infinispan-dev at lists.jboss.org
>> > https://lists.jboss.org/mailman/listinfo/infinispan-dev
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev