[infinispan-issues] [JBoss JIRA] Commented: (ISPN-156) TransactionXaAdapter.prepare not called by JBossTM

[Manik Surtani (JIRA)]

    [ https://jira.jboss.org/jira/browse/ISPN-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12482476#action_12482476 ] 

Manik Surtani commented on ISPN-156:
------------------------------------

I've added a modified version of Lukasz's test to trunk.

The test passes with the DummyTransactionManager but fails with JBossTS.  

The crux of the problem is that JBossTS performs commit() calls on the registered TransactionXAResource instance but no prepare().  This has to do with JBossTS optimising the transaction to a single-phase tx since there is only one resource registered.  And this causes the TransactionXAResource to skip some vital steps in prepare().

The correct solution is to modify TransactionXAResource to call prepare() in commit(), if onePhase is true.  The TM passes the onePhase parameter to commit() so this information is available.


> TransactionXaAdapter.prepare not called by JBossTM
> --------------------------------------------------
>
>                 Key: ISPN-156
>                 URL: https://jira.jboss.org/jira/browse/ISPN-156
>             Project: Infinispan
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 4.0.0.ALPHA6
>            Reporter: Mircea Markus
>            Assignee: Manik Surtani
>            Priority: Blocker
>             Fix For: 4.0.0.BETA1
>
>
> More details on this email: http://lists.jboss.org/pipermail/infinispan-dev/2009-August/001102.html
> Logs show that TransactionXaAdapter.prepare doesn't get called. Interestingly enough, commit gets called. This might be related with TM seeing the resource as read-only, so prepare would not make sense here. Also a warning is being logged: 
> 13:12:10,281  WARN arjLoggerI18N:302 - [com.arjuna.ats.arjuna.coordinator.TxControl_1] - Name of XA node not defined. Using -3f57fe92:744:4a83f50a:1
> Logs and source code in the email.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira