[infinispan-issues] [JBoss JIRA] Commented: (ISPN-134) Update ManagedAttribute annotations to expose more information for use by JOPR

Thu Aug 27 06:58:23 EDT 2009

    [ https://jira.jboss.org/jira/browse/ISPN-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12482996#action_12482996 ] 

Mircea Markus commented on ISPN-134:
------------------------------------

manik: This thread http://lists.jboss.org/pipermail/infinispan-dev/2009-July/000883.html also has info
[1:36pm] manik: but basically
[1:36pm] mmarkus_: also re:coherence migration, I think that will take about 3 days by itself, as I really have to understand coherence first
[1:36pm] manik: Ah ok
[1:36pm] manik: (the jopr stuff should take a few hrs IMO)
[1:36pm] mmarkus_: I would do that together with a feature comparison with coherence (ISPN-46)
[1:37pm] mmarkus_: kewl, I take your word for that 
[1:37pm] manik: well basically
[1:37pm] manik: Heiko has already written the jopr plugin
[1:37pm] manik: the only problem is that all of the JMX names and types are hard-coded in XML
[1:37pm] manik: E.g., the jopr plugin refers to an XML file
[1:37pm] manik: which tells it where all of the JMX attribs are
[1:37pm] manik: now this sucks
[1:37pm] mmarkus_: i c
[1:37pm] manik: sunce every time we need to add a jmx attrib
[1:38pm] manik: we need to update this XML as well
[1:38pm] mmarkus_: where is the hand written xml now?
[1:38pm] manik: so I think we can generate this XML
[1:38pm] manik: http://fisheye.jboss.org/browse/Infinispan/trunk/jopr-plugin/src/main/resources/META-INF
[1:38pm] manik: in trunk, under the jopr-plugin module
[1:39pm] mmarkus_: i c
[1:39pm] manik: basically most of this info is already available in our @MBean annotations
[1:39pm] mmarkus_: and the code that generates it should be in jopr-plugin module as well, i think?
[1:39pm] manik: well, the way I see it
[1:40pm] manik: this should be generated an build-time
[1:40pm] manik: and not at runtime
[1:40pm] manik: I.e., when we build a release, the build process generates this XML and packages it with the jopr-plugin jar
[1:40pm] manik: so we already have 3 psot-comple processes running in the 'tools' module
[1:41pm] manik: 1) generate the config docs - http://infinispan.sourceforge.net/4.0/apidocs/config.html
[1:41pm] manik: 2) generate the jmx docs - http://infinispan.sourceforge.net/4.0/apidocs/jmxComponents.html
[1:41pm] manik: and 3) generate the XSD schema from the annotations on Configuration
[1:41pm] mmarkus_: ah i c
[1:41pm] manik: so I think a 4th step can be added here, to generate the jopr XML
[1:42pm] mmarkus_: and how do these post-compile tools get called?
[1:42pm] manik: maven has hooks for this
[1:43pm] manik: e.g.
[1:43pm] mmarkus_: I'm looking at pom.xml for tools
[1:43pm] manik: http://fisheye.jboss.org/browse/Infinispan/trunk/core/pom.xml?r=728
[1:43pm] manik: line 88
[1:43pm] manik: Tools only builds the code that will do the generation
[1:43pm] manik: tools doesnt have the build hooks
[1:43pm] manik: the build hooks will be in whichever module that needs it
[1:43pm] manik: e.g., core needs the XSD to be generated
[1:44pm] manik: so it calls the XSD generator in core/pom.xml : 88
[1:44pm] manik: The Maven <process-classes> phase happens after <compile>
[1:45pm] manik: So you could easily write something similar to generate the JOPR XML
[1:45pm] manik: now here is one thing:
[1:45pm] manik: the JOPR XML needs more info than we have in the @MBean annotations
[1:45pm] mmarkus_: i c
[1:45pm] manik: and hence my discussion in the email thread above
[1:45pm] manik: do we enhance the annotations to include this extra info?  Or (for now) can we just make assumptions?
[1:46pm] manik: Ideally I would like to add the extra info in the annotations
[1:46pm] mmarkus_: i'll have to add something similar to the pom.xml in jopr-module
[1:46pm] manik: Yup
[1:46pm] mmarkus_: I c
[1:47pm] manik: well, have a look and a think and see what you feel - I think it should be pretty straightforward stuff.  It is just reformatting metadata after all...
[1:47pm] manik: metadata inannotation -> metadata in XML
[1:47pm] mmarkus_: yep, much clearer to me now
[1:47pm] mmarkus_: I'll update the jira with the conversation
[1:47pm] manik: ok great
[1:48pm] manik: also update with the link to the discssion thread on infinispan-dev
[1:48pm] manik: since that has a lot of info as well
[1:48pm] manik: To test the jopr plugin, you can follow these steps
[1:48pm] manik: http://www.jboss.org/community/wiki/MonitoringInfinispanwithJopr
[1:48pm] mmarkus_: mailing list, you mean?
[1:48pm] manik: yes
[1:49pm] mmarkus_: I'll paste the conversation, that includes the link
[1:50pm] manik: ok

> Update ManagedAttribute annotations to expose more information for use by JOPR
> ------------------------------------------------------------------------------
>
>                 Key: ISPN-134
>                 URL: https://jira.jboss.org/jira/browse/ISPN-134
>             Project: Infinispan
>          Issue Type: Feature Request
>          Components: JMX, reporting and management
>            Reporter: Manik Surtani
>            Assignee: Mircea Markus
>             Fix For: 4.0.0.CR1
>
>
> Details are in the mail list thread.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira