[infinispan-issues] [JBoss JIRA] Issue Comment Edited: (ISPN-133) Upgrade JClouds to a version that depends on Apache HTTP Core that fixes HTTPCORE-199

[Galder Zamarreno (JIRA)]

    [ https://jira.jboss.org/jira/browse/ISPN-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12526456#action_12526456 ] 

Galder Zamarreno edited comment on ISPN-133 at 4/19/10 9:24 AM:
----------------------------------------------------------------

----- "Philippe Van Dyck" <pvdyck at gmail dot com> wrote:

> On Mon, Apr 19, 2010 at 12:36 PM, <galder at jboss dot org> wrote:
> 
> > Hi Philippe,
> >
> > So, to sum up, trying to fix
> ISPN-133 won't solve your problem,
> correct? Did you test this out by any chance?
> >
> 
> Yep, "Basically InputStream#available() is utterly broken.".
> GzipIbputStream's implementation is :
>  public int available() throws IOException {
>         ensureOpen();
>         if (reachEOF) {
>             return 0;
>         } else {
>             return 1;
>         }
>     }
> 
> You definitely cannot use the return value to set your buffer size.

Interesting. It seems like it's not only Apache's HTTP client library that did not care much about available() implementations, but also JDK classes as well. I'd rather read on 1k batches than 1 byte batches. See things like this, I'm even less inclined to urgently look into https://jira.jboss.org/jira/browse/ISPN-133.

      was (Author: galder.zamarreno at jboss.com):
    ----- "Philippe Van Dyck" <pvdyck at gmail dot com> wrote:

> On Mon, Apr 19, 2010 at 12:36 PM, <galder at jboss dot org> wrote:
> 
> > Hi Philippe,
> >
> > So, to sum up, trying to fix
> https://jira.jboss.org/jira/browse/ISPN-133won't solve your problem,
> correct? Did you test this out by any chance?
> >
> 
> Yep, "Basically InputStream#available() is utterly broken.".
> GzipIbputStream's implementation is :
>  public int available() throws IOException {
>         ensureOpen();
>         if (reachEOF) {
>             return 0;
>         } else {
>             return 1;
>         }
>     }
> 
> You definitely cannot use the return value to set your buffer size.

Interesting. It seems like it's not only Apache's HTTP client library that did not care much about available() implementations, but also JDK classes as well. I'd rather read on 1k batches than 1 byte batches. See things like this, I'm even less inclined to urgently look into https://jira.jboss.org/jira/browse/ISPN-133.
  
> Upgrade JClouds to a version that depends on Apache HTTP Core that fixes HTTPCORE-199
> -------------------------------------------------------------------------------------
>
>                 Key: ISPN-133
>                 URL: https://jira.jboss.org/jira/browse/ISPN-133
>             Project: Infinispan
>          Issue Type: Thirdparty Change
>          Components: Loaders and Stores
>            Reporter: Galder Zamarreno
>            Assignee: Galder Zamarreno
>             Fix For: 4.1.0.CR1, 4.1.0.Final
>
>
> https://issues.apache.org/jira/browse/HTTPCORE-199
> Remove temporary workaround in ISPN-119 as part of this:
> http://fisheye.jboss.org/browse/Infinispan/trunk/core/src/main/java/org/infinispan/marshall/AbstractMarshaller.java#514

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira