[infinispan-issues] [JBoss JIRA] Resolved: (ISPN-342) File.separator used in a regular expression

[Manik Surtani (JIRA)]

     [ https://jira.jboss.org/jira/browse/ISPN-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Manik Surtani resolved ISPN-342.
--------------------------------

    Resolution: Done


Thanks for reporting.  Yes, I don't think many folks test on Windows... although its weird the Findbugs plugin in our Hudson setup did not pick this up.

> File.separator used in a regular expression
> -------------------------------------------
>
>                 Key: ISPN-342
>                 URL: https://jira.jboss.org/jira/browse/ISPN-342
>             Project: Infinispan
>          Issue Type: Bug
>    Affects Versions: 4.0.0.CR4
>            Reporter: Sanne Grinovero
>            Assignee: Manik Surtani
>            Priority: Critical
>             Fix For: 4.0.0.GA
>
>
> In class org.infinispan.util.ClassFinder , method toClassName(String fileName) is using File.separator in a regular expression; on Windows this is going to be given the value "\" which is an escape character in a regular expression.
> (found by findbugs, apparently nobody here is testing on Windows)
> Findbugs suggest to replace it with
> File.separatorChar=='\\' ? "\\\\" : File.separator

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira