[infinispan-issues] [JBoss JIRA] Resolved: (ISPN-314) Enhance test fwk to report when a resource was not properly cleaned by a test

[Mircea Markus (JIRA)]

     [ https://jira.jboss.org/jira/browse/ISPN-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mircea Markus resolved ISPN-314.
--------------------------------

    Resolution: Done


I've added a sanity check to verify weather all the CacheManagers created by a test are being shutdown within the same test[1].
The cool part is that if a CM is not being closed, the fwk will report you where the unclosed CacheManager was created (java file and line, see bellow), so that you don't have to spend too much time looking into code ;)
E.g.

[pool-2-thread-7] Test testTxChangesOnAtomicMap(org.infinispan.atomic.AtomicMapFunctionalTest) succeeded.
Test suite progress: tests succeeded: 179, failed: 1, skipped: 0.
[pool-2-thread-7] Test testTxChangesOnAtomicMapNoLocks(org.infinispan.atomic.AtomicMapFunctionalTest) succeeded.
Test suite progress: tests succeeded: 180, failed: 1, skipped: 0.

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!!!!!! (pool-2-thread-7) Exiting because atomic.AtomicMapFunctionalTest has NOT shut down all the cache managers it has started !!!!!!!
!!!!!! (pool-2-thread-7) The still-running cacheManager was created here: org.infinispan.atomic.AtomicMapFunctionalTest.setUp(AtomicMapFunctionalTest.java:33) !!!!!!!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!


> Enhance test fwk to report when a resource was not properly cleaned by a test
> -----------------------------------------------------------------------------
>
>                 Key: ISPN-314
>                 URL: https://jira.jboss.org/jira/browse/ISPN-314
>             Project: Infinispan
>          Issue Type: Feature Request
>            Reporter: Mircea Markus
>            Assignee: Mircea Markus
>             Fix For: 4.1.0.ALPHA1, 4.1.0.Final
>
>
>  if  a test fails and didn't clean up resources properly (in this case destroy the cache managers) then next test running on the same thread will see the already existing cluster, and blockUntil.. methods will fail.
> Make the fwk report that a cluster is not properly shutdown by a test, when another tries to create a cluster.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira