[infinispan-issues] [JBoss JIRA] Resolved: (ISPN-487) Log byte arrays partially in Hot Rod client

[Mircea Markus (JIRA)]

     [ https://jira.jboss.org/browse/ISPN-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mircea Markus resolved ISPN-487.
--------------------------------

    Resolution: Done


done - thanks for the suggestion.
I've also improved o.i.u.Util.printArray to support null arrays (it was throwing NPE for such arrays, so couldn't be a dropin replacement for Arrays.toString)

> Log byte arrays partially in Hot Rod client
> -------------------------------------------
>
>                 Key: ISPN-487
>                 URL: https://jira.jboss.org/browse/ISPN-487
>             Project: Infinispan
>          Issue Type: Task
>          Components: Cache Server
>            Reporter: Galder Zamarreno
>            Assignee: Mircea Markus
>            Priority: Minor
>             Fix For: 4.1.0.CR2
>
>
> In SerializationMarshaller I see this:
>          if (log.isTraceEnabled()) {
>             log.trace("Unmarshalled bytes: " + Arrays.toString(bytes) + " and returning object: " + o);
>          }
> Using Arrays.toString() is Ok for most cases but if the serialized version is too big, it'd be hard to read trace logs.
> Instead, you should prob use a similar method to the one used by the HotRod/Memcached or when lazy deserialization is used where I call o.i.u.Util.printArray. This methods prints the byte array partially, only the first 10 bytes I believe, and if -Dinfinispan.arrays.debug=true is passed, it then prints the full array. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira