[infinispan-issues] [JBoss JIRA] Commented: (ISPN-310) CacheLoader preload should only load as many entries as configured by eviction max entries

Manik Surtani (JIRA) jira-events at lists.jboss.org
Wed Mar 10 08:42:39 EST 2010


    [ https://jira.jboss.org/jira/browse/ISPN-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12519189#action_12519189 ] 

Manik Surtani commented on ISPN-310:
------------------------------------

This was a big one.  So we now have CacheLoader.load(int maxEntries) which returns a Set.  The preload code uses this method *if* eviction is enabled *and* maxElements > -1.  Otherwise it uses loadAll().

> CacheLoader preload should only load as many entries as configured by eviction max entries
> ------------------------------------------------------------------------------------------
>
>                 Key: ISPN-310
>                 URL: https://jira.jboss.org/jira/browse/ISPN-310
>             Project: Infinispan
>          Issue Type: Feature Request
>          Components: Loaders and Stores
>            Reporter: Manik Surtani
>            Assignee: Mircea Markus
>             Fix For: 4.1.0.BETA1, 4.1.0.Final
>
>
> This will prevent loading too much into memory causing OOMs, as well as unnecessary eviction thread churn.  Probably would require another CacheLoader interface method such as loadAll(int maxEntries).  A default version of this method could just call loadAll() and trim the resultset to size, and more sophisticated impls could only load the necessary number of entries, such as a LIMIT SQL query for the JDBC cache stores.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the infinispan-issues mailing list