[infinispan-issues] [JBoss JIRA] Resolved: (ISPN-638) Exceptions thrown by command invocation in CallInterceptor.handleDefault(...) are hidden by catch cause

[Manik Surtani (JIRA)]

     [ https://jira.jboss.org/browse/ISPN-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Manik Surtani resolved ISPN-638.
--------------------------------

    Resolution: Done


Accepting patch - with thanks!

> Exceptions thrown by command invocation in CallInterceptor.handleDefault(...) are hidden by catch cause
> -------------------------------------------------------------------------------------------------------
>
>                 Key: ISPN-638
>                 URL: https://jira.jboss.org/browse/ISPN-638
>             Project: Infinispan
>          Issue Type: Bug
>    Affects Versions: 4.0.0.Final, 4.1.0.Final, 4.2.0.ALPHA1
>            Reporter: Paul Ferraro
>            Assignee: Manik Surtani
>             Fix For: 4.2.0.BETA1, 4.2.0.Final
>
>         Attachments: patch.txt
>
>
> If CallInterceptor.handleDefault(...) is called with a RemoteTxInvocationContext, and if command invocation throws an exception, the catch clause ends up hiding this with an IllegalStateException.
> The culprit is RemoteTxInvocationContext.isValidRunningTx(), which internally calls RemoteTxInvocationContext.getRunningTransaction(), which always throws an ISE.
> If this method would instead return null, RemoteTxInvocationContext.isValidRunningTx() will return false, and all is well, and the genuine exception can propagate properly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira