[infinispan-issues] [JBoss JIRA] Commented: (ISPN-835) State transfer should not force all invocations to be synchronous

[Manik Surtani (JIRA)]

    [ https://issues.jboss.org/browse/ISPN-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575952#comment-12575952 ] 

Manik Surtani commented on ISPN-835:
------------------------------------

No, senders still track pending prepares and writes.  That is a whole different story.  The replay mechanism has nothing to do with senders; it is to ensure modifications by third-parties (other nodes - not just the state transfer sender and receiver) who send updates to the joiner replay the message to the joiner after the joiner applies its state.  It is to support this replay that we force sync repl.




> State transfer should not force all invocations to be synchronous
> -----------------------------------------------------------------
>
>                 Key: ISPN-835
>                 URL: https://issues.jboss.org/browse/ISPN-835
>             Project: Infinispan
>          Issue Type: Bug
>          Components: RPC, State transfer
>    Affects Versions: 4.1.0.Final, 4.2.0.CR4
>            Reporter: Galder Zamarreño
>            Assignee: Manik Surtani
>            Priority: Critical
>             Fix For: 4.2.1.Final, 5.0.0.BETA1, 5.0.0.Final
>
>
> Enabling state transfer is forcing even asynchronous caches to become synchronous.
> A better way is needed to make sure state transfer works correctly (sync calls needed here) while normal replication calls remain asynchronous.
> See https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/remoting/transport/jgroups/CommandAwareRpcDispatcher.java#L254 where the response mode is overridden based on whether replay is supported.  And replay support is always on when state transfer is enabled:
> https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/remoting/rpc/RpcManagerImpl.java#L101
> Need to explore whether a joiner flag can be maintained based on a view change, and replay only supported when a joiner is still "joining", and not otherwise.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira